Add handleRedirectCallback is missing in angular documenation - Githubissues

AzureAD / microsoft-authentication-library-for-js

Microsoft Authentication Library (MSAL) for JS

http://aka.ms/aadv2

MIT License

3.67k stars 2.65k forks source link

Add handleRedirectCallback is missing in angular documenation #1466

Closed StefanSchoof closed 4 years ago

StefanSchoof commented 4 years ago

Library

[ ] msal@1.x.x or @azure/msal@1.x.x
[ ] @azure/msal-browser@2.x.x
[ ] @azure/msal-angular@0.x.x
[x] @azure/msal-angular@1.x.x
[ ] @azure/msal-angularjs@1.x.x

Documentation location

[ ] docs.microsoft.com
[ ] MSAL.js Github Wiki
[ ] README file
[x] Other (https://www.npmjs.com/package/@azure/msal-angular and https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-angular/README.md)
[ ] Documentation does not exist

Description

The documentation does say nothing about handleRedirectCallback. If this is not added a error about the need to define a handleRedirectCallback is displayed in the browser console. To find how this should be done you need to dig into the sample and find: https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/3e32907a3300f281318df171e79cdf32cc3156ad/samples/angular9-sample-app/src/app/app.component.ts#L26

StefanSchoof commented 4 years ago

Okay, just saw https://github.com/AzureAD/microsoft-authentication-library-for-js/pull/1358, so this will not required in the next release