Unhandled Promise rejection: endpoints_resolution_error in Firefox

deepti1805 commented 3 years ago

Library

[x] @azure/msal-browser@2.x.x

Framework

[ ] Angular
[ ] React
[ ] Other

Description

When we try to login from Firefox we are getting Unhandled Promise rejection: endpoints_resolution_error error. It is working as expected in Chrome.

Error Message

Unhandled Promise rejection: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: TypeError: NetworkError when attempting to fetch resource. ; Zone: ; Task: Promise.then ; Value: ClientAuthError: endpoints_resolution_error: Error: could not resolve endpoints. Please check network and try again. Detail: TypeError: NetworkError when attempting to fetch resource.

AuthError index.es.js:109

ClientAuthError index.es.js:389

createEndpointDiscoveryIncompleteError index.es.js:426

createDiscoveredInstance index.es.js:5677

step index.es.js:74

verb index.es.js:55

rejected index.es.js:46

Angular 23

sendGetRequestAsync FetchClient.ts:21

step msal-browser.js:80

verb msal-browser.js:61

__awaiter msal-browser.js:54

e Angular

__awaiter msal-browser.js:50

sendGetRequestAsync msal-browser.js:7983

discoverEndpoints index.es.js:2152

step index.es.js:74

verb index.es.js:55

1 index.es.js:48

e Angular

__awaiter$1 index.es.js:44

discoverEndpoints index.es.js:2150

resolveEndpointsAsync index.es.js:2201

step index.es.js:74

verb index.es.js:55

fulfilled index.es.js:45

Angular 2

MSAL Configuration

// Provide configuration values here.
// For Azure B2C issues, please include your policies.

Reproduction steps

1) Go to https://www.amtrak.com/tickets/travelers.html 2) Try to login from inline signin not from header. 3) open inspector tool and you will be able to see this error. Note : Error is coming only in the case of inline signin and in Firefox.

// Provide relevant code snippets here.
// For Azure B2C issues, please include your policies.

Expected behavior

It should work in Firefox as well

Identity Provider

[ ] Azure B2C Custom Policy

Browsers/Environment

[ ] Firefox

Regression

[ ] Did this behavior work before? Version:

Security

[ ] Is this issue security related?

Source

[ ] Internal (Microsoft)
[ ] Customer request

tnorling commented 3 years ago

@deepti1805 Can you please try upgrading to the latest version 2.12.0 and let us know if this is still happening?

deepti1805 commented 3 years ago

@tnorling I am still getting this error-

tnorling commented 3 years ago

@deepti1805 Can you try opening the url in the error message in a new tab in your firefox browser? Can you confirm that it opens a page with a json structure similar to: https://login.microsoftonline.com/common/v2.0/.well-known/openid-configuration

deepti1805 commented 3 years ago

@tnorling It seems to be similar structure.

tnorling commented 3 years ago

@deepti1805 I followed the repro steps you shared above and I'm seeing in the network tab your app is making 2 simultaneous calls to loginRedirect. One request appears to be cancelling the other which is resulting in the error you're seeing. Can you try to determine why your app is calling loginRedirect multiple times?

deepti1805 commented 3 years ago

@tnorling ok I got your point but still we can see this issue in firefox only. This is working absolutely correct in Chrome.

tnorling commented 3 years ago

@deepti1805 Even in chrome I am seeing your app make 2 calls. The timing between Chrome and Firefox may be slightly different which is why you're seeing the error in Firefox but not Chrome. In Chrome you'll see a cancelled /authorize call instead of the /openid-configuration call. The cancelled /authorize call does not throw an error because it's a redirect and the 2nd one causes the page to leave, whereas, the /openid-configuration call is a GET request which throws this error. The solution in this case for both Firefox and Chrome is to ensure that your app is only calling loginRedirect once.

deepti1805 commented 3 years ago

@tnorling Thanks for your information. I am working on it.

github-actions[bot] commented 3 years ago

This issue has not seen activity in 14 days. If your issue has not been resolved please leave a comment to keep this open. It will be closed in 7 days if it remains stale.

github-actions[bot] commented 3 years ago

This issue has been closed due to inactivity. If this has not been resolved please open a new issue. Thanks!

AzureAD / microsoft-authentication-library-for-js