search

AzureAD / microsoft-authentication-library-for-js

Microsoft Authentication Library (MSAL) for JS
http://aka.ms/aadv2
MIT License
3.64k stars 2.65k forks source link

Use inject in MsalRedirectComponent #6006

Open grosch-intl opened 1 year ago

grosch-intl commented 1 year ago

Core Library

MSAL.js v2 (@azure/msal-browser)

Wrapper Library

MSAL Angular (@azure/msal-angular)

Public or Confidential Client?

Public

Description

In the alpha for v3, would you please modify MsalRedirectComponent so that instead of injecting the MsalService via the constructor, you instead use the inject(MsalService) option? If you do that, we can stop providing a constructor in our component for the sole purpose of sending you a service.

Source

External (Customer)

hectormmg commented 1 year ago

@grosch-intl thanks for the feature request. We'll look into it but as a general rule we're not doing API breaking changes for v3. We're limiting updates to default behavior breaking changes and some tooling enhancements.

@EmLauber can we track this feature request for Angular v3? Thanks!

ghost commented 1 year ago

@grosch-intl This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.

EmLauber commented 1 year ago

Tracking internally and keeping open as a feature enhancement for breaking changes.