AzureAD / microsoft-authentication-library-for-js

Microsoft Authentication Library (MSAL) for JS
http://aka.ms/aadv2
MIT License
3.58k stars 2.63k forks source link

Vite/Vue3, dependency scan issue (packageMetadata in msal-browser) #6805

Closed daglenn1960 closed 6 months ago

daglenn1960 commented 7 months ago

Core Library

MSAL.js (@azure/msal-browser)

Core Library Version

3.6.0

Wrapper Library

Not Applicable

Wrapper Library Version

n/a

Public or Confidential Client?

Public

Description

Issue with @azure/msal-browser (happens with any msal-browser 3.x.x. version):

Error Message

This error came from the "onResolve" callback registered here:

node_modules/vite/node_modules/esbuild/lib/main.js:1292:20:
  1292 │       let promise = setup({
       ╵                     ^

at setup (file:///C:/afni_dev/afniACM/AfniAcm/node_modules/vite/dist/node/chunks/dep-68d1a114.js:44748:19)
at handlePlugins (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:1292:21)
at buildOrContextImpl (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:978:5)
at Object.buildOrContext (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:786:5)
at C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:2186:68
at new Promise (<anonymous>)
at Object.context (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:2186:27)
at Object.context (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:2026:58)
at prepareEsbuildScanner (file:///C:/afni_dev/afniACM/AfniAcm/node_modules/vite/dist/node/chunks/dep-68d1a114.js:44531:26)

at failureErrorWithLog (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:1649:15)
at C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:1058:25
at runOnEndCallbacks (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:1484:45)
at buildResponseToResult (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:1056:7)
at C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:1068:9
at new Promise (<anonymous>)
at requestCallbacks.on-end (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:1067:54)
at handleRequest (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:729:19)
at handleIncomingPacket (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:755:7)
at Socket.readFromStdout (C:\afni_dev\afniACM\AfniAcm\node_modules\vite\node_modules\esbuild\lib\main.js:679:7)

Msal Logs

No response

MSAL Configuration

export const msalConfig = {
  auth: {
    clientId: configGetValue("func_api_clientid"), // afniformsaastestfunc 
    authority: configGetValue("func_api_authority"),
    redirectUri: configGetValue("redirect_uri"), // Must be registered as a SPA redirectURI on your app registration
    postLogoutRedirectUri: configGetValue("redirect_uri") // Must be registered as a SPA redirectURI on your app registration
  },
  cache: {
    cacheLocation: 'localStorage'
  },
  system: {
      loggerOptions: {
          loggerCallback: (level, message, containsPii) => {
              if (containsPii) {
                  return;
              }
              switch (level) {
                  case LogLevel.Error:
                      console.error(message);
                      return;
                  case LogLevel.Info:
                      // console.info(message);
                      return;
                  case LogLevel.Verbose:
                      // console.debug(message);
                      return;
                  case LogLevel.Warning:
                      console.warn(message);
                      return;
                  default:
                      return;
              }
          },
          logLevel: LogLevel.Verbose
      }
  }
};

Relevant Code Snippets

n/a, vite fails to run application

Reproduction Steps

npm run dev

Expected Behavior

Running dev environment

Identity Provider

Azure AD / MSA

Browsers Affected (Select all that apply)

Chrome, Edge

Regression

No response

Source

External (Customer)

tnorling commented 6 months ago

The referenced file does exist in the published package. We are not experts in Vite and can't speculate as to why this is breaking with your toolchain. If there's specific changes we need to make to support this please feel free to open a PR or a new issue with suggestions.