AzureAD / microsoft-authentication-library-for-js

Microsoft Authentication Library (MSAL) for JS
http://aka.ms/aadv2
MIT License
3.64k stars 2.65k forks source link

MatchingResources Missing From msal.interceptor.config.ts #7255

Closed oliverdrummond closed 1 month ago

oliverdrummond commented 2 months ago

Core Library

MSAL.js (@azure/msal-browser)

Core Library Version

msal-angular-v3.0.23

Wrapper Library

MSAL Angular (@azure/msal-angular)

Wrapper Library Version

msal-angular-v3.0.23

Public or Confidential Client?

Public

Description

Until v3.0.18, msal.interceptor.config.ts had the export for MatchingResources

export type MatchingResources = {
  absoluteResources: Array<string>;
  relativeResources: Array<string>;
};

On version 3.0.19 the export was removed and still not available on v3.0.23

Error Message

TS2305: Module '"@azure/msal-angular/msal.interceptor.config"' has no exported member 'MatchingResources'.

MSAL Logs

No response

Network Trace (Preferrably Fiddler)

MSAL Configuration

{
    auth: {
            clientId: authConfig.clientId,
            authority: `https: //login.microsoftonline.com/${authConfig.tenantId}`, // Defaults to 'https://login.microsoftonline.com/common'
            redirectUri: baseHref + '/auth/', // Points to window.location.origin. You must register this URI on Azure portal/App Registration.
            postLogoutRedirectUri: baseHref + '/',
    },
        cache: {
            cacheLocation: BrowserCacheLocation.LocalStorage,
            storeAuthStateInCookie: isIE,
    },
        system: {
            loggerOptions: {
                loggerCallback(logLevel: LogLevel, message: string) {
                    console.log(message)
            },
                logLevel: LogLevel.Info,
                piiLoggingEnabled: false
        }
    },
}

Relevant Code Snippets

export type MatchingResources = {
  absoluteResources: Array<string>;
  relativeResources: Array<string>;
};

Reproduction Steps

  1. Just check the diff between version 3.0.18 and 3.0.19

Expected Behavior

Keep the exported type or provide an alternative

Identity Provider

Entra ID (formerly Azure AD) / MSA

Browsers Affected (Select all that apply)

Chrome, Firefox, Edge, Safari

Regression

3.0.18

Source

External (Customer)

tnorling commented 2 months ago

This type was never part of the public surface so you should not be dependent on it. Some of the implementation details of the interceptor needed to change to fix some bugs which is why this was removed.

Can you help me understand the impact of its removal to your specific requirements so I might suggest an alternative approach using API stable exports?

microsoft-github-policy-service[bot] commented 1 month ago

@oliverdrummond This issue has been automatically marked as stale because it is marked as requiring author feedback but has not had any activity for 5 days. If your issue has been resolved please let us know by closing the issue. If your issue has not been resolved please leave a comment to keep this open. It will be closed automatically in 7 days if it remains stale.