Closed diegojerezba closed 2 months ago
Added a few comments. Otherwise, lgtm
I'd suggest to manually run the pipeline on this branch as a sanity check
Done: https://identitydivision.visualstudio.com/IDDP/_build/results?buildId=1320628&view=results
Proposed changes
This PR adds a new check in the pr-validation.yml. It consists in an integration of the changes of the current branch into the NativeAuth Sample App using a Swift Package.
These are the steps that are done:
Note: I have checked the
build.py
script and I think it's different enough from what we are trying to do here, so I thought it is better to have two separate jobs, even if both scripts build the framework. I'm open to discussion on this.The time it takes the PR-validation hasn't been incremented, as it runs in parallel and this job takes ~6-10 min.
The following tests have been done:
Type of change
Risk