Unify log levels in Native Auth

[diegojerezba]

Proposed changes

This PR unifies the logging level across all the NativeAuth classes using the MSAL Obj logging criteria. As some of these decisions can be a bit subjective, opinionated comments are more than welcome.

Main changes:

• For the logs regarding the flow (such as "Performing resetpassword/challenge request"), we are now using .info level, in a similar way MSAL Objc does (for example, see: MSIDLocalInteractiveController.m)
• For the errors that don't block the user, like those regarding the cache, we are now using .warning level, in a similar way as MSAL Obj does (for example, see: MSALAccountsProvider.m)

Type of change

• [ ] Feature work
• [ ] Bug fix
• [ ] Documentation
• [ ] Engineering change
• [ ] Test
• [x] Logging/Telemetry

Risk

• [ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
• [ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
• [x] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

[nilo-ms]

@diegojerezba can you please clarify when different of log levels are used? And can you align with MSAL Android too? Thanks

[spetrescu84]

I'm looking at the 3 .verbose messages in MSALNativeAuthSignUpController.swift: MSALLogger.log(level: .verbose, context: context, format: "credential_required received in signup/continue request") MSALLogger.log(level: .verbose, context: context, format: "attributes_required received in signup/continue request: \(attributes)") MSALLogger.log(level: .verbose, context: context, format: "attributes_required received in signup/continue request: \(attributes)") Should they also be .info? The ones in the other files - MSALNativeAuthCredentialsController.swift and MSALNativeAuthTokenResponseValidating.swift look ok. Overall we have a way fewer verbose messages than the ones in the .m files

[diegojerezba]

MSALNativeAuthCredentialsController

I'm looking at the 3 .verbose messages in MSALNativeAuthSignUpController.swift: MSALLogger.log(level: .verbose, context: context, format: "credential_required received in signup/continue request") MSALLogger.log(level: .verbose, context: context, format: "attributes_required received in signup/continue request: \(attributes)") MSALLogger.log(level: .verbose, context: context, format: "attributes_required received in signup/continue request: \(attributes)") Should they also be .info? The ones in the other files - MSALNativeAuthCredentialsController.swift and MSALNativeAuthTokenResponseValidating.swift look ok. Overall we have a way fewer verbose messages than the ones in the .m files

I've changed the logs in MSALNativeAuthSignUpController.swift into .info. Thanks @spetrescu84