[macOS SDK] Update macOS minimum version to 10.15

AzureAD / microsoft-authentication-library-for-objc

Microsoft Authentication Library (MSAL) for iOS and macOS

http://aka.ms/aadv2

MIT License

260 stars 142 forks source link

[macOS SDK] Update macOS minimum version to 10.15 #2220

Closed spetrescu84 closed 1 month ago

spetrescu84 commented 3 months ago

Proposed changes

Update macOS minimum version to 10.15

Type of change

[x] Feature work
[ ] Bug fix
[ ] Documentation
[ ] Engineering change
[ ] Test
[ ] Logging/Telemetry

Risk

[ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
[ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
[x] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Additional information

nilo-ms commented 3 months ago

@spetrescu84 I noticed that in the MSAL project we have many places where we check the macOS version" "if (@available(macOS 10.15, *))". Can you please remove these checks given than now they're not needed anymore?

spetrescu84 commented 3 months ago

@spetrescu84 I noticed that in the MSAL project we have many places where we check the macOS version" "if (@available(macOS 10.15, *))". Can you please remove these checks given than now they're not needed anymore?

Removed all instances of if (@available(macOS 10.15, *)) from MSAL Project. Any that are left should be part of IdentityCore project (not all MSID files are) and will removed as part of the IdentityCore PR

Veena11 commented 2 months ago

Let's merge this PR only after the July release is out