Add E2E tests for email OTP MFA feature - Githubissues

AzureAD / microsoft-authentication-library-for-objc

Microsoft Authentication Library (MSAL) for iOS and macOS

http://aka.ms/aadv2

MIT License

262 stars 142 forks source link

Add E2E tests for email OTP MFA feature #2331

Closed nilo-ms closed 1 month ago

nilo-ms commented 1 month ago

Proposed changes

This PR contains the following 2 E2E tests:

test_signInUsingPasswordWithMFASubmitWrongChallengeResendChallengeThen_completeSuccessfully
test_signInUsingPasswordWithMFAGetAuthMethods_thenCompleteSuccessfully
test_signInUsingPasswordWithMFANoDefaultAuthMethod_completeSuccessfully

These tests are currently disabled because the lab tenant isn't allowlisted yet.

The first test checks the following three scenarios. These scenarios could be merged in one single test speeding up the execution:

Submit wrong challenge
resend challenge
submit correct challenge

Type of change

[ ] Feature work
[ ] Bug fix
[ ] Documentation
[ ] Engineering change
[X] Test
[ ] Logging/Telemetry

Risk

[ ] High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
[ ] Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
[X] Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)