AzureAD / microsoft-authentication-library-for-python

Microsoft Authentication Library (MSAL) for Python makes it easy to authenticate to Microsoft Entra ID. General docs are available here https://learn.microsoft.com/entra/msal/python/ Stable APIs are documented here https://msal-python.readthedocs.io. Questions can be asked on www.stackoverflow.com with tag "msal" + "python".
https://stackoverflow.com/questions/tagged/azure-ad-msal+python
Other
801 stars 200 forks source link

Use assertRaisesRegex instead of assertRaisesRegexp for Python 3.12 compatibility #445

Open tirkarthi opened 2 years ago

tirkarthi commented 2 years ago

The deprecated unittest aliases were removed in python/cpython#28268 . The PR is backwards compatible with Python 2

ghost commented 2 years ago

CLA assistant check
All CLA requirements met.

jiasli commented 2 years ago

Ha. This is another evidence showing that Python 2 support should be dropped (https://github.com/AzureAD/microsoft-authentication-library-for-python/issues/406). 🤣

rayluo commented 2 years ago

Interestingly, we just added Python 3.11alpha into our test matrix in another PR, the test automation passed without the changes in this PR. Manually trying in a Python 3.11alpha environment, and the assertRaisesRegexp is still available.

tirkarthi commented 1 year ago

Probably the tests are getting skipped in test_client.py

tirkarthi commented 1 year ago

The removal was done 3.12 https://docs.python.org/3.12/whatsnew/3.12.html#removed

bgavrilMS commented 12 months ago

@rayluo - please let's prioritize community contributions when possible and avoid keeping PRs open for longer than a few days / weeks.