AzureAD / microsoft-authentication-library-for-python

Microsoft Authentication Library (MSAL) for Python makes it easy to authenticate to Microsoft Entra ID. General docs are available here https://learn.microsoft.com/entra/msal/python/ Stable APIs are documented here https://msal-python.readthedocs.io. Questions can be asked on www.stackoverflow.com with tag "msal" + "python".
https://stackoverflow.com/questions/tagged/azure-ad-msal+python
Other
801 stars 200 forks source link

Upstream PyJWT has vulnerability issue- CVE-2022-29217 Prevent key confusion through non-blocklisted public key formats. GHSA-ffqj-6fqr-9h24 #473

Closed llawwaii closed 2 years ago

llawwaii commented 2 years ago

Describe the bug PyJWT is a Python implementation of RFC 7519. PyJWT supports multiple different JWT signing algorithms. With JWT, an attacker submitting the JWT token can choose the used signing algorithm. The PyJWT library requires that the application chooses what algorithms are supported. The application can specify jwt.algorithms.get_default_algorithms() to get support for all algorithms, or specify a single algorithm. The issue is not that big as algorithms=jwt.algorithms.get_default_algorithms() has to be used. Users should upgrade to v2.4.0 to receive a patch for this issue. As a workaround, always be explicit with the algorithms that are accepted and expected when decoding.

https://www.mend.io/vulnerability-database/CVE-2022-29217

Could you please upgrade pyjwt from 2.3.0 to 2.4.0 to fix the vulnerability.

rayluo commented 2 years ago

Hi Wai, thanks for bringing that upstream dependency PyJWT's decoding vulnerability to our attention. After examination, we believe MSAL Python's usage of PyJWT is insusceptible to this issue, because: (1) MSAL Python only uses PyJWT for encoding, not for decoding; (2) MSAL Python already allows downstream apps to freely upgrade to latest PyJWT 2.4.0 (for example, pip install -U pyjwt).