search

AzureAD / microsoft-authentication-library-for-python

Microsoft Authentication Library (MSAL) for Python makes it easy to authenticate to Microsoft Entra ID. General docs are available here https://learn.microsoft.com/entra/msal/python/ Stable APIs are documented here https://msal-python.readthedocs.io. Questions can be asked on www.stackoverflow.com with tag "msal" + "python".
https://stackoverflow.com/questions/tagged/azure-ad-msal+python
Other
754 stars 191 forks source link

Remove newlines from description / Fix summary. #626

Closed micwoj92 closed 7 months ago

micwoj92 commented 7 months ago

When trying to build wheel it gives warning

writing msal.egg-info/PKG-INFO
/usr/lib/python3.11/site-packages/setuptools/dist.py:173: SetuptoolsDeprecationWarning: Invalid config.
!!

        ********************************************************************************
        newlines are not allowed in `summary` and will break in the future
        ********************************************************************************

!!
  write_field('Summary', single_line(summary))

This can be seen in latest wheel on pypi msal-1.25.0-py2.py3-none-any.whl summary field in METADATA file is incomplete, it only states: Summary: The Microsoft Authentication Library (MSAL) for Python library

rayluo commented 7 months ago

Thanks for bringing this to our attention.

Out of curiosity, why would you need to build a wheel (thus run into this issue) in the first place? I believe a standard pip install msal will already install a wheel that we already build for you.

micwoj92 commented 7 months ago

The issue (description being cut after first newline) is also present in the wheel.

rayluo commented 7 months ago

The issue (description being cut after first newline) is also present in the wheel.

True, and your finding was legit.

I was just curios to know that in what scenario you would need to build a wheel from source. Most people just pip install an already-built wheel, and would not even notice that issue.

Regardless, this PR will be kept open for one more day, in case you would like to reply back. We will merge this PR afterwards.

micwoj92 commented 7 months ago

I was just curios to know that in what scenario you would need to build a wheel from source. Most people just pip install an already-built wheel, and would not even notice that issue.

This module is available in AUR. The package builds python-msal from source.