search

AzureAD / microsoft-authentication-library-for-python

Microsoft Authentication Library (MSAL) for Python makes it easy to authenticate to Microsoft Entra ID. General docs are available here https://learn.microsoft.com/entra/msal/python/ Stable APIs are documented here https://msal-python.readthedocs.io. Questions can be asked on www.stackoverflow.com with tag "msal" + "python".
https://stackoverflow.com/questions/tagged/azure-ad-msal+python
Other
754 stars 191 forks source link

Enable public client ROPC via broker #712

Closed fengga closed 1 week ago

fengga commented 1 week ago

If use_broker enabled, ROPC flows on windows will call into WAM, on macOS will call MSAL C++ logic.

rayluo commented 1 week ago

Sorry, @fengga , my bad, I forgot to mention that, in general, all broker-relevant changes must be tested locally, rather than solely rely on the test pipeline, because we did not figure out a way to install broker into MSAL Python's current pipeline. (You may also tackle how to setup broker in test pipeline, but no need to do it in this PR.)

In this particular case, since your one-liner change was reverting a previous change, you could also have use Github's blame feature to find the previous change's PR and realize that there was a test case there. That test case is now failing because we changed the implementation now. Please come up with a new PR (can be in this same branch) to adjust that test case, too.