search

AzureAD / rms-sdk-for-cpp

RMS SDK for C++
MIT License
29 stars 15 forks source link

Task #1450265: Implement SetTags function #156

Closed shenhavba closed 7 years ago

msftclas commented 7 years ago

@shenhavba, Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA. Thanks, Microsoft Pull Request Bot

vakuras commented 7 years ago

XMPFileFormat::XMPFileFormat(shared_ptr file, const string& extension)

incorrect parameter names #Closed

Refers to: sdk/file_sdk/XMPFileFormat/xmp_file_format.cpp:19 in c367613. [](commit_id = c3676134a6fede159cea651042385cbf16be7c6c, deletion_comment = False)

shenhavba commented 7 years ago

XMPFileFormat::XMPFileFormat(shared_ptr file, const string& extension)

what is incorrect?

In reply to: 330146383 [](ancestors = 330146383)

Refers to: sdk/file_sdk/XMPFileFormat/xmp_file_format.cpp:19 in c367613. [](commit_id = c3676134a6fede159cea651042385cbf16be7c6c, deletion_comment = False)

vakuras commented 7 years ago

XMPFileFormat::XMPFileFormat(shared_ptr file, const string& extension)

file -> inputStream

In reply to: 330196320 [](ancestors = 330196320,330146383)

Refers to: sdk/file_sdk/XMPFileFormat/xmp_file_format.cpp:19 in c367613. [](commit_id = c3676134a6fede159cea651042385cbf16be7c6c, deletion_comment = False)