AzureDoom / dotHackWeapons

Brings 600+ weapons from dothack into Minecraft.
https://minecraft.curseforge.com/projects/dothack-hack-models
MIT License
2 stars 1 forks source link

idea: config file #2

Closed kreezxil closed 5 years ago

kreezxil commented 5 years ago

if mine and slash & eb wizardry are now completely optional, can you add a config that allows to tell your mod to ignore them?

I have mine and slash and ebwizardry in my pack but dothack detects them, and I am currently rolling ebwiz down to 4.1.4 because a nuissance sound bug issue. It would be nice to not have to roll dothack down too because it is detecting ebwiz and getting upset.

AzureDoom commented 5 years ago

This is due to the staffs and such using new code that was added in 1.4 of EB Wizardry to fix the upgrading bug I found (upgrading outputs a EB Wizadry wand instead of an upgraded version of mine) by not allowing my items to be upgraded currently.

AzureDoom commented 5 years ago

66c0e57 now the mod should state that it requires 4.2 and up of EB Wizardry for the integration to work. I understand the issues with EB 4.2 but it has code that 4.1 does not to fix the upgrading issue.

kreezxil commented 5 years ago

oh, this is where I know you from.

On Wed, Aug 28, 2019 at 2:03 AM AzureZhen notifications@github.com wrote:

Closed #2 https://github.com/AzureZhen/dotHackWeapons/issues/2.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/AzureZhen/dotHackWeapons/issues/2?email_source=notifications&email_token=AA5TJCESHGSJS3HVC45FCZLQGYPL3A5CNFSM4IPTCU42YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOTJLYKEY#event-2589426963, or mute the thread https://github.com/notifications/unsubscribe-auth/AA5TJCFVWVJXWE6E45KN6ADQGYPL3ANCNFSM4IPTCU4Q .