AzureMarker / intellij-lalrpop

Jetbrains plugin for the LALRPOP parser-generator
MIT License
16 stars 2 forks source link

Remove missing terminals inspection object fields #21

Closed dnbln closed 3 years ago

dnbln commented 3 years ago

Fixes #20

dnbln commented 3 years ago

From what I can tell the UserDataHolderBase seems to be thread-safe, so maybe also change the ConcurrentLinkedQueues to plain ArrayList and the AtomicBooleans to plain Booleans?

AzureMarker commented 3 years ago

It looks like UserDataHolderBase is thread-safe in that setting a value is atomic, but performing a get and then modifying the value internally (such as using add on a list) is not inherently thread safe, so we need to keep the concurrent/atomic classes.