search

Azurency / CQUI_Community-Edition

Civilization 6 mod - UI enhancements, reduce clicks and manage your empire faster!
MIT License
399 stars 98 forks source link

Some files for 1.0.0.216 #283 #286

Closed FightofLife closed 6 years ago

FightofLife commented 6 years ago

Hey, i´m new to civ modding/lua scriptting. But i thought 'let´s try' - so i did some files. Maybe it helps :)

Panels/citypanel.xml
Panels/citypaneloverview.xml
Popups/boostunlockedpopup.lua
Popups/mappinpopup.xml
Popups/techciviccompletedpopup.lua
Popups/wonderbuiltpopup.lua
Screens/techtree.lua
ToolTips/plottooltip.lua
productionpanel.xml
toppanel.lua
toppanel.xml
worldtracker.lua
worldtracker.xml

for #283

Azurency commented 6 years ago

Thank you for this contribution 👍. Will have to review the changes and test it.

Azurency commented 6 years ago

I just gave a very quick look at your changes, and you sometime used tabs instead of 2 spaces could you try to fix this ?

FightofLife commented 6 years ago

Hey, sry - yeah, ich will fix it! (u want a "fixing-commit" or should i change the history of the branch? (guess if i change history i should create new PR - or?)

Azurency commented 6 years ago

Whatever you're more confortable with. You can change the history of your branch, it will automatically update the pull request I think. And a fix commit is not a problem, I'll squash the commits upon merge.

FightofLife commented 6 years ago

So i made a new commit where i changed all tabs by double space. (if it was to much replacing tell me - then i will reset and just replace my tabs by spaces ;-) )

FightofLife commented 6 years ago

Ok, i did the changes.

Azurency commented 6 years ago

Thank you for your help and contribution on the update 🎉 !

FightofLife commented 6 years ago

Hey Azurency, thank you for all your work :)

Next time i will be more focused on indentations!