Azuro-protocol / Live-Betting-Bug-Report

3 stars 1 forks source link

[Live Betting Test]: Use EIP712 rather than vanilla eth_sign #6

Closed Luigy-Lemon closed 1 month ago

Luigy-Lemon commented 4 months ago

Contact Details

luigy_lemon@protonmail.com

Your Wallet Address

0xc44caeb7F0724A156806664d2361fD6f32a2d2C8

Testing Scenario Conducted

Bug Patterns

Test Description

When live betting in the mumbai testnet I submit a new bet.

Observed Behavior

When a new bet is submitted there is a request to eth_sign the bet order.

Expected Behavior

I would expect a more modern signature format to be used. EIP712 is a preferale signature method as it extends on the vanilla eth_sign but allows the user to validate in a readable way what exactly they are signing, instead of a simple hash.

Reproducibility of the Issue

Any new bet in the live market on mumbai

Additional Information

image

No response

Avvrik commented 4 months ago

Score added: https://api.azuro.org/score/0xc44caeb7F0724A156806664d2361fD6f32a2d2C8/transactions