search

AzzamAlsharafi / ideapad-controls-gnome-extension

GNOME Shell extension for controling Lenovo IdeaPad laptops options.
GNU General Public License v3.0
27 stars 4 forks source link

Update for GNOME 47 and improve translations support #16

Open Woomymy opened 10 months ago

Woomymy commented 10 months ago

Update for GNOME 45 support, update screenshots and format / cleanup some parts of the code.

GNOME 45 introduces breaking changes so older versions will no longer be supported

This should pass e.g.o guidelines this time. Thanks for your work on this extension, woomy

Woomymy commented 10 months ago

The last commit is unrelated to GNOME 45 update but should improve the translations for some langages as requested in #13. I can seperate it in another PR if you want

AzzamAlsharafi commented 10 months ago

Hello,

First I want to thank you sir, you're the only person keeping this project alive. I have to apologize though, as it's probably going to take me a while to review this PR, as I'm currently very busy at the moment.

Regarding the translation improvement no need to separate to another PR.

Woomymy commented 10 months ago

Hi, no problem if it takes you a while to review this and I'm happy to help if it can save you some time / help to keep this project alive. Thanks for precision for translation PR.

(also, to any user / dev reading this, if you want contribute by testing changes / giving some reviews, that would be welcome and very appreciated, thanks!)

4JX commented 9 months ago

2021 Lenovo Legion 5 Pro (16ach6h) here, conservation/fn lock work fine.

My camera setup is borked somewhere and I don't have an USB charger to test with, so there's that.

josselinonduty commented 2 days ago

Fixes #14

@Woomymy you seem to be an active contributor. You should maybe fork and publish

ViBE-HU commented 2 days ago

this extension is a very useful one. i am a nobody but would be good if someone could maintain it or fork it as a Lenovo Vantage alternative since the platform and the features are not Ideapad specific and Lenovo users have no Linux solution to control these settings which is a bummer..