AzzamAlsharafi / ideapad-controls-gnome-extension

GNOME Shell extension for controling Lenovo IdeaPad laptops options.
GNU General Public License v3.0
27 stars 5 forks source link

Enable switch between 'Tray' and 'System Menu' without an extension reload #2

Closed CorvetteCole closed 1 year ago

CorvetteCole commented 1 year ago

This can be done quite easily by attaching a listener for that settings change in the enable() function, just make sure to detach it in disable().

I may implement this myself at some point if I have time and if desired by the maintainer

AzzamAlsharafi commented 1 year ago

I wasn't aware that you can connect a listener to the settings, I thought you could only do "bind" which is limited. Thanks for the tip, I'll implement it now.

CorvetteCole commented 1 year ago

maybe I misspoke and meant binding, you can see how blur-my-shell does it here: https://github.com/aunetx/blur-my-shell/blob/master/src/extension.js

AzzamAlsharafi commented 1 year ago

Yeah I get what you mean. I already did it using settings.connect().