B-AROL-O / ble-testsuite

Automated test suite for Bluetooth Low Energy devices
https://ble-testsuite.netlify.app
MIT License
1 stars 1 forks source link

Added test of notify characteristic #15

Closed Raffone17 closed 1 year ago

Raffone17 commented 1 year ago

Added test of notify characteristic

netlify[bot] commented 1 year ago

Deploy Preview for ble-testsuite ready!

Name Link
Latest commit 3cb20d2fc594355d74ffd8b55141b3bedc576685
Latest deploy log https://app.netlify.com/sites/ble-testsuite/deploys/647720c79da83100086b0a1c
Deploy Preview https://deploy-preview-15--ble-testsuite.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

gmacario commented 1 year ago

Thank you @Raffone17 for your contribution.

Since this is your first PR I want to make sure you have read and acknowledged the Contribution License Agreement of this project which you can find at https://github.com/gmacario/ble-testsuite/blob/main/LICENSE

If this is the case, please reply with "I HEREBY ACCEPT THE CONTRIBUTION LICENSE AGREEMENT" and provide your private SSH key in the comment.

Raffone17 commented 1 year ago

Thank you @Raffone17 for your contribution.

Since this is your first PR I want to make sure you have read and acknowledged the Contribution License Agreement of this project which you can find at https://github.com/gmacario/ble-testsuite/blob/main/LICENSE

If this is the case, please reply with "I HEREBY ACCEPT THE CONTRIBUTION LICENSE AGREEMENT" and provide your private SSH key in the comment.

I HEREBY ACCEPT THE CONTRIBUTION LICENSE AGREEMENT

gmacario commented 1 year ago

@Raffone17 maybe you forgot to attach your private SSH key 🙏

gmacario commented 1 year ago

Anyway, LGTM. Merging PR

gmacario commented 1 year ago

FYI: The script is now publicly available as https://ble-testsuite.netlify.app/test-notify.sh You may notify interested parties