B-Lang-org / bsc

Bluespec Compiler (BSC)
Other
954 stars 146 forks source link

Cleanups in C, Tcl, and GitHub CI #703

Closed quark17 closed 6 months ago

quark17 commented 6 months ago

These are misc cleanups that I made while exploring adding the new GHC 9.10.1 to our GitHub CI.

  1. Updates an ancient C syntax used in bluetcl_Main.hsc that newer compilers warn will be deprecated in newer C standards (-Wdeprecated-non-prototype).
  2. Cleans up how the tcllibs flags are computed in platform.sh, to remove TCL_VER (which was a duplicate definition and which was being improperly define anyway due to a syntax error). More significantly, this adds the version number to the flag for macOS (from -ltcl to -ltcl8.5) -- which was intended to be added, but because TCL_VER was failing to be defined properly, an empty string was being appended. It's better to have the version suffix, just to ensure that the right library is being picked up.
  3. Add support in the GitHub CI for leaving the hls_version field blank, to indicate that the HLS testing step should be skipped. This allows for testing newer GHC installations that are available in GHCUP but don't yet have HLS supportin GHCUP.