search

B-Open / jobbuzz

Brunei job search database and alert notification
https://jobbuzz.org
MIT License
1 stars 1 forks source link

paginating scraper #38

Closed syahnur197 closed 2 years ago

syahnur197 commented 2 years ago

closes #20

also closes #39

codecov-commenter commented 2 years ago

Codecov Report

Merging #38 (e4c8d3a) into main (f9323b3) will decrease coverage by 2.87%. The diff coverage is 1.16%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   18.33%   15.45%   -2.88%     
==========================================
  Files           5        5              
  Lines         180      220      +40     
==========================================
+ Hits           33       34       +1     
- Misses        138      177      +39     
  Partials        9        9
Impacted Files Coverage Δ
pkg/scraper/bruneida_scraper.go 5.71% <0.00%> (-0.64%) :arrow_down:
pkg/scraper/jobcenter_scraper.go 5.00% <0.00%> (-3.00%) :arrow_down:
pkg/scraper/scraper.go 25.00% <33.33%> (+0.75%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f9323b3...e4c8d3a. Read the comment docs.

dsychin commented 2 years ago

Overall comment, the current code is not modular and too integrated and makes it hard to write test code. It is fine for now but should be improved in the future.

syahnur197 commented 2 years ago

Overall comment, the current code is not modular and too integrated and makes it hard to write test code. It is fine for now but should be improved in the future.

looking forward to see how we can make it modular