B-enguin / pe

0 stars 0 forks source link

Undo/Redo Feature seems out of place #17

Open B-enguin opened 11 months ago

B-enguin commented 11 months ago

Description:

Screenshot 2023-11-17 at 5.34.08 PM.pngScreenshot 2023-11-17 at 5.34.08 PM

Undo/redo feature heavily mentions AddressBook which was not mentioned in the DG. And seems out of place with the rest of the features mentioned.

Justification for Severity:

Might hinder reader understanding, however is correct with regards to the codebase, hence VeryLow

nus-se-bot commented 11 months ago

Team's Response

Rejected: The Undo and Redo features are implementations that we are considering to implement in the future therefore the use of header Proposed Implementation instead of Implementation. Furthermore, the references to AddressBook should not seem out of place since we have mentioned it in the Architecture section of the DG (e.g. under Model as seen below):

image.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]