Fix Cinnamon 3.2.2 Support for Themes

[daemonspudguy]

I have an issue on the latest version of Cinnamon. I am using the XP Themes. All themes are strange looking.

[daemonspudguy]

[Elbullazul]

add the following code at the end of the cinnamon.css file. I think it should fix it, at least until cinnamon 3.2 gets stable enough I can work on it without problem.

.starkmenu-background {
    border: solid 1px transparent;
    border-image: url("menu-bg.png") 12 12 67 42;
    box-shadow: 2px 2px 2px rgba(0,0,0,0.5);
    padding: 55px 1px 29px 1px;
}

[dominichayesferen]

@jacobpoo Yeah, unfortunately, Cinnamon kinda broke every theme when it comes to that thanks to their attempt at uniformity for menus...

[daemonspudguy]

@Elbullazul Thank you, thank you, thank you

[daemonspudguy]

@Elbullazul I fixed up your code and this is how you it. .menu { border: solid 1px transparent; border-image: url("menu-bg.png") 12 12 67 42; box-shadow: 2px 2px 2px rgba(0,0,0,0.5); padding: 55px 1px 29px 1px; }

[Elbullazul]

@jacobpoo thanks, I didn't know that mint had changed .menu-background for .menu

I'll try to add this to the current themes so you don't have to patch them

[daemonspudguy]

@Elbullazul Okay, sounds good

[dominichayesferen]

@jacobpoo @Elbullazul I'm pretty sure .menu and .menu-background are still two different things, .menu-background being for menus themselves, and .menu for being popup menu BGs...

[Elbullazul]

@feren maybe...

@jacobpoo can you post a screenshot of the right-click menu on the panel?

[daemonspudguy]

I will after school. I am currently in high school and as such have no access to my Linux custom build at home at the moment.

[daemonspudguy]

@feren is the same for both now in cinnamon 3.2

[dominichayesferen]

Oh ok...

[daemonspudguy]

@Elbullazul If you allow me, I can fix up the xp themes.

[Elbullazul]

you can create a fork of the repo and submit a pull request when changes are done. Then I can merge changes and seeing what has changed.

[dominichayesferen]

@jacobpoo If you're not familiar with Pull Requests: When you're ready, go to This Repo > Pull Requests > New Pull Request, then on the following site, make it compare this repository to your fork of it (make sure though that this repository (the target) is on the top of the page, and not yours), and then add a title & description as you please then hit 'Submit Pull Request'...

[daemonspudguy]

@Elbullazul @feren Okay. i will happily.

[daemonspudguy]

@feren

[dominichayesferen]

Yeah, that was what I was thinking about, they used to be separate menus...

[dominichayesferen]

@jacobpoo ...beforehand, they looked like blocky/3D menus for non-menu menus...

Which part of CSS is making it look like that?

[dominichayesferen]

@jacobpoo PS: Is that XP Themes, or CinnXP for Metacity & Cinnamon? Haven't seen those changes myself...

[daemonspudguy]

@feren XP Themes, I am using my patched themes.

[dominichayesferen]

@jacobpoo Oh ok, wasn't sure if the Metacity spacing was fixed by Elbullazul or not...

[daemonspudguy]

@feren Okay

[daemonspudguy]

@feren .menu is the css part in the cinnamon.css file.

[dominichayesferen]

@cinnamoner 0.0.X releases on Cinnamon tend to just be minor updates and fixes whilst 0.X.0 releases are the MAJOR updates to Cinnamon...

[Elbullazul]

@jacobpoo do you happen to use starkmenu with the themes?

[daemonspudguy]

@Elbullazul CinnVIIStarkMenu

[daemonspudguy]

@Elbullazul Can you port Vista to gtk3.20

[Elbullazul]

actually, I'm not shure I want to; @bluedxca93 has already aero themes for 3.20:

• aero, a port of our current vista base
• adaero, another style but still close to aero

maybe I'll tweak it to add the aero headerbars, but that would be all

[daemonspudguy]

@Elbullazul oh... Okay.

[dominichayesferen]

@Elbullazul Umm, on Global Application Menu by Lestcape, the menus are Vista-styled, also, what happened to the StarkMenu shutdown buttons reverse-compatibility?

[Elbullazul]

@feren oups, forgot retro-compatibility...

[Elbullazul]

re-added feature

[daemonspudguy]

@Elbullazul Can you please fix the themes for CinnVIIStarkMenu?

[NikoKrause]

@Elbullazul I've tested your XP Luna theme with the newest version of CinnVIIStarkMenu. It seems, that starkmenu-background doesn't pull information form menu-background as it did in previous versions. But it works, if you do the trick you mentioned above:

.starkmenu-background {
    border: solid 1px transparent;
    border-image: url("menu-bg.png") 12 12 67 42;
    box-shadow: 2px 2px 2px rgba(0,0,0,0.5);
    padding: 54px 1px 29px 1px;
}

P.S.: Maybe the following is a matter of taste: Since Cinnamon 3.2 the vfade effect it enabled by default. It looks ugly in the XP theme. I would reduce it or setting it to 0px:

StScrollView.vfade {
  -st-vfade-offset: 0px;
}

[Elbullazul]

@NikoKrause thanks for your fix, it really helps get the old XP feeling back :D

@jacobpoo the bug is now fixed, I updated the code, but you need the newest version of CinnVII from Nikokrause, here

[Elbullazul]

here's how it now looks:

[NikoKrause]

The searchbox is invisible. Maybe using something similar like in CinnXP (a blue border):

[Elbullazul]

I thought I had dealt with it :/

thanks for messaging, patch coming out soon...

[Elbullazul]

@NikoKrause issue fixed, just issued a corrective