B00merang-Project / Redmond-Themes

Home of the B00merang Redmond Collection themes for Linux
http://b00merang.weebly.com/redmond-collection.html
187 stars 12 forks source link

Add GTK 3.20 support #2

Closed capitanx closed 7 years ago

capitanx commented 8 years ago

The current themes don't work in GTK 3.20 due the CSS changes. https://blogs.gnome.org/mclasen/2015/11/20/a-gtk-update/

ghost commented 8 years ago

is ambiance ported to gtk 3.20. a pure css (not scss) based port to gtk3 is needed.

Please do try to ask raveit/ulbricht from mate themes for an idea.dont know him but it might be useful to ask him for a hint. think its time to wait a bit. 3.20 changes are heavy and the number of themes for 3.20 decreased for a reason.

Elbullazul commented 8 years ago

@capitanx sorry for the late reply, hadn't seen these issues.

just like @bluedxca93 says, 3.20 break a lot of things and I don't even have a stable code base to work on (Windows 10 for 3.20 is on beta and still lots of substitutions needed)

I'll let you know whenever I've finished working on the base code, and then count maybe two weeks till all themes are compatible

hope gnome 3.22 won't break themes harder than 3.20 did...

ghost commented 8 years ago

@elbulazull check my port script from bluedxca93 18/20 .it substitutes a lot of classes already.trained it against adwaita and traditional ok.

also use GTK_DEBUG=interactive gtkapplication name.

ghost commented 8 years ago

@Elbullazul now loaded up aero expirimental based on 3.20 . ccbyncnd . for heavy mods cc by nc sa

Elbullazul commented 8 years ago

@bluedxca93 I just checked, aero works (almost flawlessly)! Just one more thing, the notebooks are the same whatever their state : fedora 24 alpha aero

ghost commented 8 years ago

@Elbullazul noted some changes i'll add to my porting script.There are some bugs left in the script and the theme. The script can't make a full port actually. notebook and toolbar/headerbar as well as one menu type needs some future improvement. But it works stable enough to work a bit with it.One bug that really is anoing is selected foreground/background.Scrollbar is also not final but the progress is not bad..

Elbullazul commented 8 years ago

@bluedxca93 yeah, it's definetely better than Metadata

progressbar is actually pretty nice, I'm fixing mine with padding

I'm kind of annoyed that gnome 3.22 is coming out in september already and we're just getting started with themes...

ghost commented 8 years ago

im only doing aero for 3.20 no need to port other themes to. it. 3.18 is in an ubuntu lts release. 3.22 will delete some more gtk classes . Itll be more seigned for scss. However scss is only good for logical mostly flat skins.

Elbullazul commented 8 years ago

@bluedxca93 I had a look at the original adwaita css and scss files

man, scss was awful long and had WAY MORE styling elements (plus colors are defined in a weird manner)

ghost commented 8 years ago

@Elbullazul some of these are missing, but adwaita is also missing some style elements. But its the same on gtk 18 adwaita and ambiance. the scss layout also generates sometimes states like checked:focus:hover:backdrop. where is that necessary?

Elbullazul commented 8 years ago

as far as I know, this looks OK to start porting the Redmond Collection to 3.20, right?

screenshot from 2016-06-17 08-17-14

ghost commented 8 years ago

@elbullazul It looks nice. Problem might be that this works definitely well on 8 and 10 but aero luna etc. possibly not. what codebase did you use?. send now ravefinity a patched ambiance version.Ambiance needs rewrite.can you send me css bundled out of scss from numix?

Elbullazul commented 8 years ago

@bluedxca93 I used the original adwaita theme (lots of gradients), so I think it should behave normally

distributing the colors will be a little harder

I'll have a look at the numix code and come back later

ghost commented 8 years ago

@elbullazul scale.vertical slider instead of scale slider.vertical. hope it helps...

On 6/17/16, Christian Medel notifications@github.com wrote:

@bluedxca93 I used the original adwaita theme (lots of gradients), so I think it should behave normally

distributing the colors will be a little harder

I'll have a look at the numix code and come back later


You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/Elbullazul/Redmond-Themes/issues/2#issuecomment-226777412

Elbullazul commented 8 years ago

@bluedxca93 I'm seriously considering to port the themes instead of doing a compete rewrite. I'll let you know if I write patches for known issues.

P. S. The text selected color issue may be related to the textview class or tag

ghost commented 8 years ago

https://github.com/bluedxca93/aero-experimental will be updated soon.

textview issue found and fixed. notebook fixed a bit more.(im not finished with it.).

maybe you can write changes in this way whenever possible:

s/original_string/patched_string/g

and change . > . : > : newline in string > \n

regards bluedxca93

Elbullazul commented 8 years ago

we started porting the Windows 3 theme to 3.20

lots of errors as of now...

Elbullazul commented 8 years ago

that went fast! almost flawless theme now! screenshot from 2016-09-19 15-57-49

ghost commented 8 years ago

looks good.

capitanx commented 8 years ago

Thank you a lot. It works perfect. :) Can be win95 the next?

Elbullazul commented 8 years ago

@capitanx we're working on it, it`s almost finished

Elbullazul commented 8 years ago

@capitanx Windows 9x for 3.20 is now pushed to the repo, haven`t got time to package it up

enjoy!

ghost commented 8 years ago

@elbullazul congrats for getting it up. You know ambiance-aero is vista like . Question Should i make luna too , or focus on ice theme set first??

On Wed, Sep 21, 2016 at 2:58 PM, Christian Medel notifications@github.com wrote:

@capitanx https://github.com/capitanx Windows 9x for 3.20 is now pushed to the repo, haven`t got time to package it up

enjoy!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Elbullazul/Redmond-Themes/issues/2#issuecomment-248604393, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJmr75ENJEoDs2eV9Wt6W-RI0SQneHhks5qsSoFgaJpZM4IxvsO .

Elbullazul commented 8 years ago

I don`t know, luna is already available (petrucci4prez)

I would say, port ice first, then luna

ghost commented 8 years ago

okay thx, i will start most probably on saturday/sunday. i can`t before cause of school/job.

On Wed, Sep 21, 2016 at 5:41 PM, Christian Medel notifications@github.com wrote:

I don`t know, luna is already available (petrucci4prez)

I would say, port ice first, then luna

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Elbullazul/Redmond-Themes/issues/2#issuecomment-248652168, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJmr7Kb8dB0D_K_Up-nJh9wzMLC9p0Wks5qsVAagaJpZM4IxvsO .

Elbullazul commented 8 years ago

@bluedxca93 how finished do you think the aero theme is?

ghost commented 8 years ago

@elbullazul check it on 3.20 and you ll see. just make a screen if you found a bug.

Elbullazul commented 8 years ago

@cinnamoner cinnamon is built for mint, and except for arch, I don`t know how it could behave

I just know that fedora 24 has cinnamon in its repos and it`s supposed to work better than the one used in ubuntu

@bluedxca93 I would add some shadows to the window frames. Aero looks too flat / disorganized without them

Elbullazul commented 8 years ago

@cinnamoner I`m waiting for @bluedxca93 to finish porting aero. Then maybe I can attack the vista theme

ghost commented 8 years ago

@elbullazul make a screen without and do and do edit this image to how it should look. then im trying my best to do that.

regards bluedxca93

On Thu, Sep 22, 2016 at 2:57 PM, Christian Medel notifications@github.com wrote:

@cinnamoner https://github.com/cinnamoner I`m waiting for @bluedxca93 https://github.com/bluedxca93 to finish porting aero. Then maybe I can attack the vista theme

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Elbullazul/Redmond-Themes/issues/2#issuecomment-248896074, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJmrxgPASEOPnjnlngbb0fDPMtfm8CIks5qsntPgaJpZM4IxvsO .

Elbullazul commented 8 years ago

ex.

aero-metacity

vs

aero-gnome

ghost commented 8 years ago

vs newest version 3.20. gtk3-widget-factory-lastest

As you can see it looks almost perfect. But its newest version from github and not your earlier setup.

Elbullazul commented 8 years ago

@bluedxca93 correct, I must have forgotten to update it

it looks nice! Can I propose you change the text-color of the titlebuttons to white with a text-shadow, so the icons look like windows aero?

rsz_0-bymvk7zo-21

ghost commented 8 years ago

@elbullazul of course yes, just write me how and ill add that feature!

On Thu, Sep 22, 2016 at 7:05 PM, cinnamoner notifications@github.com wrote:

@Elbullazul https://github.com/Elbullazul Would you bet on Manjaro Cinnamon or Apricity Cinnamon? :):)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Elbullazul/Redmond-Themes/issues/2#issuecomment-248965256, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJmr6gthH0hwNOWmla-khx0lPNy1d8Pks5qsrVOgaJpZM4IxvsO .

Elbullazul commented 8 years ago

@cinnamoner I would go with apricity, it looks neater than manjaro

@bluedxca93 something like

.titlebar .titlebutton {
    color: white;
    text-shadow: 0 0 2px black;
}
ghost commented 8 years ago

@elbullazul / @feren now early port of ice online on github, maybe make a screenshot. regards bluedxca93

On Thu, Sep 22, 2016 at 7:24 PM, cinnamoner notifications@github.com wrote:

Man, I like what I see on this thread.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Elbullazul/Redmond-Themes/issues/2#issuecomment-248970115, or mute the thread https://github.com/notifications/unsubscribe-auth/AEJmr8bugamfvTcP9jQP0wf0FmzY9Jd3ks5qsrnEgaJpZM4IxvsO .

Elbullazul commented 8 years ago

@cinnamoner please post them in a new issue report. may prove usfeful ;)

dominichayesferen commented 8 years ago

@Elbullazul Did you get the problem I posted on Gitter about the solid block? If you want to see what I mean by it:

sudo add-apt-repository ppa:elementary-os/stable
sudo apt update
sudo apt remove shotwell*
sudo apt install pantheon-photos

Then run Photos and choose a theme like Embedded as GTK

Elbullazul commented 8 years ago

fixed on latest commit

dominichayesferen commented 8 years ago

@Elbullazul It also affects macOS so if you haven't updated that one yet...

Elbullazul commented 8 years ago

I did

dominichayesferen commented 8 years ago

Nope, still happens here on the latest Git version of it: (Cinnamon Stable) screenshot from 2016-09-29 06-38-09

Elbullazul commented 8 years ago

screenshot_2016-09-29_19-04-46

pushing commit in short

Elbullazul commented 7 years ago

except for the vista theme, every other theme has 3.20 compatibility, so I'm closing it, since @bluedxca93 has the aero theme which looks OK for it to be used with the vista theme