search

B00merang-Project / Redmond-Themes

Home of the B00merang Redmond Collection themes for Linux
http://b00merang.weebly.com/redmond-collection.html
187 stars 12 forks source link

Padding in menu instead of menuitem! #3

Closed ghost closed 8 years ago

ghost commented 8 years ago

Hi,

bluedxca93 here. Can you please move padding value from .menu and GTKComboboxmenu to .menu .menuitem thx. This bug cause drawing issues on 16.04 once drawing a menu. Implementing the padding only in .menu.menuitem and other child classes fixes the weird replicating of right and bottom border.

looks like __I I __I__I

should be simply: I ___I

instead of: .menu { padding: x; }

write: .menu .menuitem { padding: x }

possibly this works too for something: .menuitem:nth-child(last) bla bla bla.

Don know if youre interested but:

gsettings set org.cinnamon.desktop.interface icon-theme 'iconthemename' gsettings set org.cinnamon.desktop.interface gtk-theme 'themename' gsettings set org.cinnamon.desktop.wm.preferences theme 'themename' gsettings set org.cinnamon.theme name 'themename'

for gnome/unity replace cinnamon with gnome. Set in iconthemename with desired icontheme and (gtk) themename.

Nortamlly this message would had been send as an pm on gnome-look, but since this site behave like a living zombie its written down here.

kind and best regards bluedxca93

ghost commented 8 years ago

@cinnamoner no my stark menu version works on 3.0.0 too. It might break on 3.2 .

@elbullazul This is gtk3 related. The menu and the toolbar design are the two most undocumented changes in gtk3. wrote here the most correctly workaround for menu. Note: You can simulate .menu padding by using an border image and padding on menuitem. This way it ll be rendered correctly on 3.8 and 3.18.

Elbullazul commented 8 years ago

Ok, if I get this well, instead of setting the padding for the menu I should set it on menu items to avoid some glitch. Right?

ghost commented 8 years ago

@elbullazul yes and you need either box-shadow inset or a border image. normally menuitem:hover schould load the value from menuitem.

@cinnamoner if i knew how i would upload most of it compressed without password from commandline to git.

Elbullazul commented 8 years ago

@bluedxca93 you know you can upload everything at once from the browser too?

you just have to create a release and upload all zips

ghost commented 8 years ago

@elbalazull first revision of sed script done, can someone send me 3.18 and 3.20 adwaita theme generated css files? do upload it today anyway on github but this would help a lot. don't know how it performs but gets a lot right already.

Elbullazul commented 8 years ago

@bluedxca93 https://git.gnome.org/browse/gtk+/plain/gtk/theme/Adwaita/gtk-contained.css is for gtk 3.20 adwaita theme source code (css, not scss)

for gtk 3.18, I don't know, I don't have the code right now

Elbullazul commented 8 years ago

@bluedxca93 would you mind attaching a screenshot of the issue? I'm just curious...

Elbullazul commented 8 years ago

this has been dealt with September's 18th Batch Release