search

B00merang-Project / Windows-10-Dark

Dark variant of Windows 10 theme
http://b00merang.weebly.com/windows-10.html
GNU General Public License v3.0
298 stars 35 forks source link

The thin line missing around windows #10

Closed RobertBoganKang closed 5 years ago

RobertBoganKang commented 5 years ago

For windows 10 theme, there is a light thin line around it so that we can see where is the windows. If there is no lines around windows, we cannot see the edge of windows since shadows under windows are also dark colors.

Elbullazul commented 5 years ago

it's there, but it's a dark shadow inherited from the light variant. Will fix

RobertBoganKang commented 5 years ago

thanks, the bug is missing now!

RobertBoganKang commented 5 years ago

I find another bug, when maximize, the buttons at top-right corner are brighter than the title bar, and the bottom thin border is still there.

RobertBoganKang commented 5 years ago

and the slider in the scroll bar (on the right side of windows, or other sliders, I cannot see it), the color are similar, in windows darker theme, it is a little bit brighter than the scroll bar.

Elbullazul commented 5 years ago

I have reworked the titlebar and scrollbar, should be fixed

RobertBoganKang commented 5 years ago
  1. the small slider (cinnamon nemo file manager fight bottom corner) still cannot see.
  2. when maximize, the right top corner buttons are slightly brighter.
Elbullazul commented 5 years ago

can you post a picture of the issue? all seems ok to me

RobertBoganKang commented 5 years ago

in Windows 10 Dark: win-10-dark-3 the progress indicator or blue or gray slider are in the dark tray, which is almost invisible for me, it should be a little bit brighter than the background such that we can see it. The edge of button or slider should be more contrast with something around it so that we can easily see where it is, so with it, we can work faster. win-10-acrylic-dark-3 this one (Windows 10 Acrylic Dark) looks great to me now. in cinnamon, when maximize, the titlebar on the top will change color, however the top right buttons remains the original color. This bug appears also in windows 10, windows 10-acrylic dark...

Elbullazul commented 5 years ago

ok, I'll rework the through widgets to improve visual difference on dark themes.

the titlebar coloring is indeed a bug, it should be easy to fix

Elbullazul commented 5 years ago

related: #149

120924e fixex the titlebar issue and 1513559 fixes the scale and progressbar through coloring. Also improves contrast with borders.