B00merang-Project / Windows-10-Fluent-Dark

Windows 10 Dark variant with black as main color
http://b00merang.weebly.com/windows-10.html
GNU General Public License v3.0
35 stars 6 forks source link

thick white border instead of usual hard-to-notice border #5

Closed sidmint closed 3 years ago

sidmint commented 3 years ago

Reproduce [shown in gif]: 1 open gnome system monitor and select button other than 'processes' [that is 'resource' or 'file systems'] 2 open another window, say a file manager 3 close newly opened window to shift focus to gnome system monitor automatically [as it's the recent most app] 4 processes button has this thick white border instead of usual hard-to-notice border usually in other themes.

Linuxmint 19.3 xfce.

2020-10-26-07:37:18

1

Elbullazul commented 3 years ago

that is intentional and in accordance with Microsoft's styling for focused buttons for Metro apps: image

if you want to manually remove that styling, I can provide assistance

sidmint commented 3 years ago

Thank you for your active involvement. I'm so content using this theme, best I found till for me.

Styling for focused buttons: Now I understood and find it okay and useful.

But I see some problems while switching it via tab button in gnome system monitor. Rectangle over 'processes' and 'resources' have only 3 white sides, next three selections are good as shown in gif, selection over the process named xfwm4 is not white at all [that may be intentional/exception for that type of area though, is that so?], and the last two selections of 'end process' and another icon [whose tool tip says 'show process properties'] has only one side as white as shown below.

1

Elbullazul commented 3 years ago

It's caused by the way GTK draws controls. Basically, a child control can't be drawn outside of its parent's boundaries. But to have the intended effect, I had to offset by 2px, so it "fails" to draw some parts of the outline.

I had another look at what grouped buttons look like without the highlight: image

there should actually be spacing between button. I should rework the buttons, probably in a short time.

Elbullazul commented 3 years ago

selection over the process named xfwm4 is not white at all [that may be intentional/exception for that type of area though, is that so?]

it is intentional. Only the buttons and text entries (if I remember correctly) are supposed to have that outline style

Elbullazul commented 3 years ago

c1fa436 corrects this issue

sidmint commented 3 years ago

Wow, thanks a lot, it's even more awesome now.