B00merang-Project / Windows-10

Windows 10 Light theme for Linux (GTK)
http://b00merang.weebly.com/windows-10.html
GNU General Public License v3.0
822 stars 119 forks source link

xfce4-panel: white-on-white text on inactive tasks #163

Closed Warudo closed 5 years ago

Warudo commented 5 years ago

Using xfce4-panel 4.14.1 on Arch Linux, the text on inactive task buttons is white while their background color is also white. This makes it impossible to read the task name.

I jury rigged it with this in ~/.config/gtk-3.0/gtk.css:

.xfce4-panel.background .tasklist button:hover {
   background-image: none;
   background-color: #1a1a1a;
}
.xfce4-panel.background .tasklist button:checked {
   background-image: none;
   background-color: #1a1a1a;
}
.xfce4-panel.background .tasklist button {
   background-image: none;
   background-color: #000000; }

xfce4-panel

dominichayesferen commented 5 years ago

Just chiming in: Surely you should put 'transparent' as the color value rather than '#000' in there?

Elbullazul commented 5 years ago

can be fixed by modifying the xfce4-panel block. Will write the fix in master and push changes

Elbullazul commented 5 years ago

a72b81e3cfe96407b2fefee8b7ae67f2891c1db6 implements the new class and should fix it (haven't tried it)

Warudo commented 5 years ago

No, the issue is still present for me even with that commit.

Elbullazul commented 5 years ago

Weird, on manjaro latest it looks normal:

VirtualBox_Manjaro 18 1 Xfce_08_10_2019_11_34_42

Do you have the panel set to follow theme rules?

Elbullazul commented 5 years ago

Found the issue. 3334492 resolves it:

VirtualBox_Manjaro 18 1 Xfce_09_10_2019_09_33_47

Warudo commented 5 years ago

Fix confirmed. Thanks!