B00merang-Project / Windows-10

Windows 10 Light theme for Linux (GTK)
http://b00merang.weebly.com/windows-10.html
GNU General Public License v3.0
812 stars 113 forks source link

Desktop icon text not visible #168

Closed thekomer closed 3 years ago

thekomer commented 4 years ago

xfce4.12 -> everything normal. xfce4.14 -> can't see text under desktop icons (i.e. Trash). Black wallpaper. See screenshot.

xfce4.12 Sc

Xfce4.14: Screenshot

Elbullazul commented 4 years ago

what distro are you using? It looks like manjaro, which unfortunately doesn't seem to play nice with my system

thekomer commented 4 years ago

MX Linux. xfce4.12 <- MX Linux 18, based on Debian 9 xfce4.14 <- MX Linux 19, based on Debian 10

thekomer commented 4 years ago

:-o Sorry about the typo. :)

BTW, here are more information that you might find useful. GTK versions used by my system:

$ dpkg -l libgtk2.0-0 libgtk-3-0
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name              Version      Architecture Description
+++-=================-============-============-=====================================
ii  libgtk-3-0:amd64  3.24.5-1     amd64        GTK+ graphical user interface library
ii  libgtk2.0-0:amd64 2.24.32-3    amd64        GTK+ graphical user interface library
Elbullazul commented 4 years ago

Apparently Xfce 4.14 upgrades Xfdesktop to GTK3, but this theme still has the rules in gtkrc.

I'll migrate based on greybird's implementation

thekomer commented 4 years ago

Yeah! The whole point of Xfce4.14 was migration from GTK 2 to GTK 3.

Xfce version 4.16, that's due in 6 months, will apparently deprecate gtk2 packages whatsoever. (I've read that somewhere)

Thank you.

Elbullazul commented 4 years ago

so I gave it a try, it looks like it still uses some GTK2 rules, and because the GTK2 theme is a big mess right now I can't find what causes the black text.

I think I might need to move over to a pixbuf-based GTK2 theme for this to fix.

Sorry for not being able to fix it quickly enough

Elbullazul commented 4 years ago

Had a new look yesterday, definetely not a GTK2 problem. At least that's one less rework to do. But I couldn't identify what caused the black text since similar themes didn't have that problem.

I'll have a deeper look tomorrow

thekomer commented 4 years ago

Thank you.

Elbullazul commented 4 years ago

Maybe it's because my version of MX isn't up to date, but it appears that the desktop icons load the globally defined variable @theme_selected_bg_color in gtk.css

As a temporary fix I suggest you edit the following line in gtk.css:

line 2856, from

@define-color theme_selected_fg_color #000000;

to

@define-color theme_selected_fg_color #ffffff;

I'll look in more detail once I have more time

Elbullazul commented 3 years ago

found a fix, coming soon

Elbullazul commented 3 years ago

should be fixed