B00merang-Project / Windows-10

Windows 10 Light theme for Linux (GTK)
http://b00merang.weebly.com/windows-10.html
GNU General Public License v3.0
812 stars 113 forks source link

Controls missing in HiDPI #178

Closed libexpand closed 3 years ago

libexpand commented 4 years ago

When the screen is scaled due to a high resolution and HiDPI is enabled, the controls are missing everywhere (the check box's and radio buttons).

OS: Kali MATE Resolution: 3840 x 2400 HiDPI enabled

Using GTK.

Missing checkbox's Screenshot at 2020-04-13 11-29-07

It should look like this (using another theme): Screenshot at 2020-04-13 11-29-31

Ben-Mathews commented 3 years ago

Same issue on Ubuntu 20.04 using Gnome / GTK

Elbullazul commented 3 years ago

Will check

jafd commented 3 years ago

You have a bunch of assets named like checkbox-unchecked@2.png, but the CSS refers to them as checkbox-unchecked-@2.png. I could probably make a PR, the only question is if those names are generated using a script (in which case the script needs fixing) or changing them manually would suffice. Also, what should be the source of truth — the asset names or the URLs in the CSS files? Which naming scheme is the correct one?

Elbullazul commented 3 years ago

Thank you so much for pointing this out. I had no clue why it was happening.

The correct naming is the asset one, without a dash before the '@'.

The correct way to fix this would be to submit a patch removing the dash from the SCSS function here, changing @return -gtk-scaled(url($filename + $extension), url($filename + "-@2" + $extension));

to

@return -gtk-scaled(url($filename + $extension), url($filename + "@2" + $extension));

Elbullazul commented 3 years ago

Or I'll do it myself in the coming hours, whatever comes first

jafd commented 3 years ago

Just a note, all themes will need to be re-generated. I'm seeing this problem in each and every theme (oh, the first-world difficulties of someone with all-HiDPI setup...)

Elbullazul commented 3 years ago

yeah, most of them used this function to generate asset paths. You can sumbit the change and I'll regen everything

Elbullazul commented 3 years ago

pushed, can anyone confirm if the bug is fixed?

jafd commented 3 years ago

I can confirm it's working for me.

Elbullazul commented 3 years ago

@jafd thank you again for finding the root of the issue.