B00merang-Project / Windows-10

Windows 10 Light theme for Linux (GTK)
http://b00merang.weebly.com/windows-10.html
GNU General Public License v3.0
819 stars 116 forks source link

Cinnamon text colors are messed up in the latest release of cinnamon with the git version of the project #69

Closed fpqc closed 7 years ago

fpqc commented 7 years ago

Hi, I'm using the latest version of the project directly from a github clone on the latest version of cinnamon. The text colors are all messed up, namely they are dark on dark. Any suggestions?

Elbullazul commented 7 years ago

hi, please include a screen shot to Illustrate the bug

fpqc commented 7 years ago

screenshot from 2016-11-23 18-59-21

By the way, cinnamon version is cinnamon 3.2.1-4.1

Elbullazul commented 7 years ago

Sorry, our theme is not yet available for cinnamon 3,2 because we haven't had time to test it on the newest cinnamon build.

fpqc commented 7 years ago

@Elbullazul If I can help in any way let me know. Thanks!

dominichayesferen commented 7 years ago

@fpqc Related Issue: https://github.com/Elbullazul/Redmond-Themes/issues/15 The easiest fix (until Cinnamon on PPAs gets the Pull Request to restore unique menus): In THEME-DIR/cinnamon/cinnamon.css:

  1. Find 'popup-menu'
  2. Copy all of the tag inside of it
  3. Paste it above
  4. Change the tag on the pasted settings to 'menu'
fpqc commented 7 years ago

Heya, I switched the git branch to testing and now the Menu works.

The only thing that looks weird now is the text-color:

screenshot from 2016-12-07 18-45-09

By the way, is there any new version of that old menu applet that looked so cool. The old one in the screenshots doesn't seem to work with cinnamon anymore.

Elbullazul commented 7 years ago

@fpqc the menu applet you talk about has been discontinued (I guess by seeing the latest commits are from 2 years from now). For now, maybe I can talk to a dev I know to adapt the configurable menu for 3.2, and then I may be able to create a new layout looking like the one in slingshot.

haven't tried this, but I guess that by adding

color: white;

to the

.window-list-item-box {

class, text should go back to white.

dominichayesferen commented 7 years ago

@fpqc Which menu was that? Looks like Cinnamon Menu

fpqc commented 7 years ago

@feren Huh? It is the cinnamon menu, but it is using the Win10 theme if you are on the testing branch of this repo. I actually cloned this repo directly into .themes, so running the testing branch was just a matter of checking it out.

Elbullazul commented 7 years ago

@fpqc did it work?

fpqc commented 7 years ago

@Elbullazul Sorry I haven't had an opportunity to test yet. Hopefully later today.

fpqc commented 7 years ago

@Elbullazul Yep. Adding that little piece in cinnamon.css fixed it all up. It seems to be working basically perfectly (screenshot below).

screenshot from 2016-12-08 20-36-13

By the way, would you mind splitting up your different theme directories into separate github repositories? It would make life a lot easier for people who want to install the themes directly from the github project:

cd ~/.themes
git clone https://github.com/B00merang-project/Windows-10-{Dark,Light}

To update the themes, all you need to do is

cd ~/.themes/Windows-10-$THEMECOLOR
git pull

To switch to the testing branch, all you need to do is:

cd ~/.themes/Windows-10-$THEMECOLOR
git checkout testing

This is much superior to installing releases and unzipping the files. It would be much much easier to do this if you split the dark and light versions up into their own repositories.

Right now, the only way to do this nicely is to turn the entire .themes directory into a clone of this repository.

Elbullazul commented 7 years ago

@fpqc agreed, it would be easier. However, I don't want to split up the theme in 2 repos, so maybe I'll add a couple new branches -> Windows 10 Dark -> Windows 10 Light -> Windows 10 Dark (testing) -> Windows 10 Dark (testing

fpqc commented 7 years ago

Thanks! You should also add the color:white line in the cinnamon.css files in the testing branch.