B00merang-Project / Windows-7

Linux theme based on the apperance of Windows 7
https://b00merang.weebly.com/windows-7.html
GNU General Public License v3.0
136 stars 13 forks source link

Lot of problems under Xubuntu 20.04 final #2

Closed ale5000-git closed 3 years ago

ale5000-git commented 4 years ago

First, thanks for the theme :)

I have some problems: 1) Background color of start menu icon wrong when menu is open and closed Fixed 2) Background color of system tray icons wrong Fixed 3) Background color of date/time icon wrong Fixed 4) The color of the text of desktop icons is wrong Fixed 5) Strange text shadow on systray icons Fixed 6) Title bar of most apps is not changed Fixed

7) The background color of the pinned apps is wrong. Here how it look now: win7-theme Compared to default theme: xubuntu-theme

9) There are also strange vertical white bars near the notification icon.

Elbullazul commented 4 years ago

will have a look at this when I have time, possibly in two weeks. Sorry for the delay

ale5000-git commented 4 years ago

Ok, thanks :)

Elbullazul commented 4 years ago

menu background is feasible but impractical at the moment. Menu button can be manually changed

Background of system tray icons wrong Background of date/time icon wrong

have been fixed.

ale5000-git commented 4 years ago

Thanks for the fixes, with "menu background" I was meaning the background color of the menu icon that is now fixed but now that you say it also the background of the entire menu need to be fixed but I think it is the less important thing.

About the menu button, in the screenschot here it appears to be changed, isn't possible to do it automatically with maybe the icon theme?

PS: The icon text on the desktop is black but it should be white with black shadow.

Elbullazul commented 4 years ago

How you can see it is mostly ok but the background color of the pinned apps is wrong.

noted.

Also if possible it would be nice if the pinned apps are positioned near the start menu and not near date/time.

that"s the panel's layout and has to be manually edited. Themes can't change that

There are also strange vertical white bars near the notification icon.

It seems to be a necessary compromise for a transparent panel, but I'll try exploring other solutions

Elbullazul commented 4 years ago

Also:

The color of the text of desktop icons is wrong

GTK loads the incorrect value for desktop labels color. Hotfix is to replace

@define-color theme_selected_fg_color #000000;

with

@define-color theme_selected_fg_color #FFFFFF;

in gtk.css

Title bar of most apps (also the file manager) is not changed

Window decorations are changed in Window manager settings. But there's no xfwm4 theme. Yet.

Shell buttons and bar wrong

that's how it is, thunar doesn't have the same layout as Windows Explorer ¯_(ツ)_/¯

Elbullazul commented 4 years ago

The menu issue is on the todo list, possibly fixed today

Elbullazul commented 4 years ago

Also:

The color of the text of desktop icons is wrong

GTK loads the incorrect value for desktop labels color. Hotfix is to replace

@define-color theme_selected_fg_color #000000;

with

@define-color theme_selected_fg_color #FFFFFF;

in gtk.css

Title bar of most apps (also the file manager) is not changed

Window decorations are changed in Window manager settings. But there's no xfwm4 theme. Yet.

Shell buttons and bar wrong

that's how it is, thunar doesn't have the same layout as Windows Explorer ¯_(ツ)_/¯

ale5000-git commented 4 years ago

that's how it is, thunar doesn't have the same layout as Windows Explorer ¯(ツ)

It doesn't need to be exactly equal but why the back, forward, up and the refresh buttons aren't changed like in Windows 7? Still Thunar is the one most similar to Windows 7 by looking here: https://wiki.ubuntu-it.org/AmbienteGrafico/FileManager

About the desktop labels color I will try.

Elbullazul commented 4 years ago

It doesn't need to be exactly equal but why the back, forward, up and the refresh buttons aren't changed like in Windows 7?

because I haven't bothered implementing it. It's technically possible, but IMO it's not worth to develop a feature for one single program.

also, last time I checked, the icon theme was supposed to have special icons for back, forward and up buttons.

but if I find time, I can try to make something similar to the original

Elbullazul commented 3 years ago

found a correction for the desktop text color, fix coming in the following weeks

Elbullazul commented 3 years ago

should be fixed

ale5000-git commented 3 years ago

@Elbullazul

Thanks, the situation improved but there are still some problems:

Elbullazul commented 3 years ago

When a desktop icon is selected the icon become completely black

I think it's because the "selected view item" has a gradient as background, but it can't be rendered in this case. I'll see if adding a backgound color anyways fixes this


 Maximize/Minimize/Close buttons aren't themed

You have to change that theme manually in settings > Window manager settings > theme

ale5000-git commented 3 years ago

By selecting Kokodi theme in these settings it look more similar, but how to get "Windows-7" theme in this list?

Elbullazul commented 3 years ago

oh, I forgot this theme doesn't have a xfwm4 theme yet. Added to the todo list

ale5000-git commented 3 years ago

I appreciate your works, thanks.

Elbullazul commented 3 years ago

added text shadow, added Xfwm4 theme. Unfortunately, couldn't find the cause of the black icons

Elbullazul commented 3 years ago
  1. Also another issue: win7-theme-icon-menu

Fixed in 5953623: image

ale5000-git commented 3 years ago

Thanks, most problems are fixed. Regarding icon selection, inside a normal folder it looks fine: Folder-selection But on the desktop is bugged: Desktop-selection

Elbullazul commented 3 years ago

e67eaa8 fixes this.

Remaining issues:

Elbullazul commented 3 years ago

d8a456e fixes the launchers

Elbullazul commented 3 years ago

4a06836 fixes the gaps around panel buttons. Couldn't manage to add in the missing shadows unfortunately, but I hope it's fixable in Xfce's next release.