search

B00merang-Project / Windows-XP

Windows XP themes
http://b00merang.weebly.com/windows-xp-themes.html
GNU General Public License v3.0
347 stars 34 forks source link

Need Close buttons for some dialogs #13

Open ghost opened 5 years ago

ghost commented 5 years ago

-Some dialogs would benefit from retaining the Close button. (In Linux Mint Cinnamon) set 'Windows XP Royale' theme; open Nemo, select 'Edit | Preferences', close dialog (client area has no Close button, so you go looking for Close button on dialog frame, but must resort to right-click titlebar and choose close). Find /home/username/.themes/Windows XP Royale/metacity-1/metacity-3.xml, and edit " " and change to hide_buttons="false. I like that this also brings back access to the upper-left window-menu (even though no icon or arrow appears).

Elbullazul commented 5 years ago

Metacity themes are due for an upgrade. Unfortunately, I've been very busy since summer ended. I would like to rebase everything on a better-suited code base than legacy code ported to v3.

@feren do you have time to rework metacity themes based on latest Windows 10? both versions 2 and 3 must be changed, but they're very similar

dominichayesferen commented 5 years ago

@Elbullazul Sorry but I probably won't have time to rework the Windows 10 Metacity Theme into an XP one, mainly because the awkwardness of making the buttons place right.

ghost commented 5 years ago

I circled back round to this one and was going to make sure I had described it right. First, I only observed that the Nemo Preferences dialog was missing a close button in the client area, but there may be others. So a close button in the title area could be useful in those cases. Second, it only appears to affect the Royale theme. The reason seems to be the presence of: <frame_geometry name="nobuttons" hide_buttons="true" parent="dialog"> </frame_geometry> However, the theme seems to rely on the presence of the tag, so the behavior apparently must be changed not by removing the tag but changing it as so: <frame_geometry name="nobuttons" hide_buttons="false" parent="dialog"> </frame_geometry>

screenshots: Screenshot from 2019-09-25 13-37-31 Screenshot from 2019-09-25 13-38-47

ghost commented 5 years ago

Now that I'm starting to figure out Pull Requests, I can create one for the change I did here (one-liner, one attribute-value really). From the Git/GitHub side, I need to figure out whether I'd need to do this second PR from another new branch (I'm thinking Yes, to keep the issues' changes separate).