search

B00merang-Project / Windows-XP

Windows XP themes
http://b00merang.weebly.com/windows-xp-themes.html
GNU General Public License v3.0
332 stars 27 forks source link

Top border in borderless mode #32

Closed AndreiMiculita closed 3 years ago

AndreiMiculita commented 3 years ago

https://github.com/B00merang-Project/Windows-XP/blob/2c396d29faaa0687c8fb1cb84541a9e1de675f53/Windows%20XP%20Luna/metacity-1/metacity-theme-3.xml#L98-L105

When in borderless mode (e.g. Firefox uses this, to show the tabs at the very top edge of the screen) there is a 6px top border. I assume it's because of the top and bottom button borders defined in normal mode, which borderless inherits from:

https://github.com/B00merang-Project/Windows-XP/blob/2c396d29faaa0687c8fb1cb84541a9e1de675f53/Windows%20XP%20Luna/metacity-1/metacity-theme-3.xml#L47

Overriding the border by adding: 

    <border name="button_border" top="0" bottom="0"/>

After line 104 seems to fix this. But my DE's weird caching interfered with testing this so I'm not sure if it introduces more issues.

It's an issue because it makes it more difficult to switch tabs, as they are not at the edge of the screen.

Elbullazul commented 3 years ago

Can you upload a screenshot of the issue?

AndreiMiculita commented 3 years ago

It happens when Firefox is maximized. Top border with XP Metallic (happens with all variations):

Note the black bar at the top, I've measured it and it's 6px.

No top border with Linux Mint-Y-Dark (the default theme in Mint):

Elbullazul commented 3 years ago

will try the fix later today

Elbullazul commented 3 years ago

@AndreiMiculita you were very close. Metacity won't parse the border override without left and right attributes. Including

<border name="button_border" left="0" right="0" top="1" bottom="0"/>

solves this. I'm pushing the fix in a little bit, thanks for pointing out the solution

Elbullazul commented 3 years ago

1216024 fixes this