B00merang-Project / Windows-XP

Windows XP themes
http://b00merang.weebly.com/windows-xp-themes.html
GNU General Public License v3.0
347 stars 34 forks source link

Weird border lines in main window in Thunar after scrollbar is scrolled at all #48

Closed ipkpjersi closed 12 months ago

ipkpjersi commented 1 year ago

Hi,

You can see at the top and the bottom here there are some weird border lines in the main Thunar window area:

Does anyone know what might be causing them? I swear I've seen similar before on Windows, but I'd prefer some way of disabling this if possible.

It's these lines, like this grey lined border:

Cheers.

Elbullazul commented 1 year ago

hello,

what GTK version are you using?

ipkpjersi commented 1 year ago

Sorry, I forgot to mention. I'm on Ubuntu 22.04 with Xfce 4.16. I am using GTK 3.20.

Here is another example of it, which is why I think it's intentional + a UI element like a picture, but I'm not sure which one it is, and I'm not sure if there's a way to disable it from the main area of Thunar: 2023-10-10_19-09-23_0

Elbullazul commented 1 year ago

You can try adding the following snippet to the end of gtk-3.20/gtk.css:

* { outline-style: none; }

and reloading the theme

ipkpjersi commented 1 year ago

I tried that and it didn't work unfortunately. It's not a huge issue though but it'd be nice to work around this somehow.

Septicity commented 12 months ago

Hey! Those weird-looking borders are from undershoot, and they just show up when there is more content in that direction (meaning you can scroll). I agree that they look kinda weird, and your goal to remove them can be accomplished:

Navigate to ~/.themes/[theme name]/gtk-3.20/gtk.css (same as Elbullazul suggested) and open it. Search "undershoot" and find the first match. You'll see 4 rules that determine what the undershoot looks like. You can comment all of them out, so they don't do anything, like so:
image

Keep in mind, this will also disable them in other applications. If you specifically want to disable them in Thunar, just replace undershoot with :not(.thunar) undershoot (I think that should work, but I'm not completely versed in GTK CSS).

ipkpjersi commented 12 months ago

That was close to working, but I ended up having to do this:

.thunar undershoot.top { background: none; padding: none; }
.thunar undershoot.bottom { background: none; padding: none; }
.thunar undershoot.left { background: none; padding: none; }
.thunar undershoot.right { background: none; padding: none; }

I'm guessing the :not syntax is not supported by GTK.

If anyone is curious about my full thunar custom CSS settings, it's here:

/* Thunar General */
.thunar { background-color: #2e2e2e; color: #e0e0e0; }

/* Thunar Sidebar - shortcuts view */
.thunar .shortcuts-pane .view { background-color: #353945; color: #e0e0e0; }

/* Thunar Sidebar - treeview */
.thunar treeview { background-color: #353945; color: #e0e0e0; }

/* Thunar Main contents view */
.thunar .standard-view .view { background-color: #404552; color: #e0e0e0; }

/* Thunar Main contents view - selection area */
.thunar .standard-view .view .rubberband { background-color: rgba(0, 122, 204, 0.3); color: initial; }

 /* Thunar Main contents view - selected folder */
.thunar .standard-view .view:selected { background-color: #007acc; color: #e0e0e0; } 

/* Thunar Main contents views - header while in list view */
.thunar .standard-view .view header button { background-color: #353945; color: #e0e0e0; }

/* Thunar Status bar */
.thunar statusbar { background-color: #353945; color: #e0e0e0; }
.thunar paned>grid { background-color: #353945; color: #e0e0e0; }

/* Thunar XP overshoot border lines */
.thunar undershoot.top { background: none; padding: none; }
.thunar undershoot.bottom { background: none; padding: none; }
.thunar undershoot.left { background: none; padding: none; }
.thunar undershoot.right { background: none; padding: none; }

Since I have a workaround again thanks to the power of CSS, I'll go ahead and close this issue.

Thanks for the help. :)