B00merang-Project / macOS

macOS theme for Gnome and GTK-based desktops
http://b00merang.weebly.com/macos.html
GNU General Public License v3.0
744 stars 118 forks source link

budgie-desktop support? (+ Budgie Desktop Support in GTK Themes Help) #50

Closed fossfreedom closed 5 years ago

fossfreedom commented 7 years ago

Hi,

untitled

Any chance that budgie-desktop support could be added with these themes?

As you can see - the top bar, sidebar are not themed correctly. This is because budgie-desktop has a couple of unique CSS elements - the .budgie and .raven stuff here https://github.com/budgie-desktop/budgie-desktop/blob/master/src/theme/3.20/sass/_main.scss

Elbullazul commented 7 years ago

@fossfreedom maybe, what gtk version does budgie use?

fossfreedom commented 7 years ago

17.04 Ubuntu Budgie uses GTK+3.22. Solus Budgie I believe uses GTK+3.24

Elbullazul commented 7 years ago

@fossfreedom I have to make room for that VM in my hdd, I'll post an update when everything is ready

dominichayesferen commented 7 years ago

@Elbullazul In case you also want to know, I believe the Budgie Remix (Older Versions before 17.04) GTKs were the same as Ubuntu's on each version... @fossfreedom , you'll have to correct me on that one if I'm wrong, also, did you see my reply about the feren OS Budgie Welcome Fork Link?

fossfreedom commented 7 years ago

@feren I hadn't seen your reply - but now that you've prompted me, thanks have now seen it. cheers for making it available.

budgie-remix 16.04 is using GTK+3.18 and budgie-remix 16.10 is using GTK+3.20

Elbullazul commented 7 years ago

@fossfreedom I have been updating some other components the last few days, tomorrow I shall get started on budgie support.

Elbullazul commented 7 years ago

@fossfreedom the file you referenced is only budgie code or only the last part?

fossfreedom commented 7 years ago

The file is the SASS code that - when compiled via npm/gulp produces GTK+ CSS code - one level up

https://github.com/budgie-desktop/budgie-desktop/tree/master/src/theme/3.20

The key areas are the .budgie and .raven elements

Other themes like Flat-Plat, Arc-Theme have these elements defined similarly

e.g. https://github.com/nana-4/Flat-Plat/blob/5d8c98c61d07ca0f21e28893cd2a6ef17f3495d6/src/gtk-3.0/3.20/gtk-compact.css

Elbullazul commented 7 years ago

@fossfreedom well, it's a bigger task that what I had expected. Do you know if all those classes are actually used?

fossfreedom commented 7 years ago

looking over the flat-plat CSS - almost all the budgie and raven classes were mapped to existing classes or just had the equivalent CSS as in the system theme (copy-paste?)

Yes all of the classes are used - there are no redundant classes there

Elbullazul commented 7 years ago

@fossfreedom Flat-Plat re-uses the existing classes. In my case, macOS has a separate look for the notification center: macos-notif-center

so it will take some time to re-theme the budgie widgets.

Also, just asking, can the window buttons be moved in budgie?

fossfreedom commented 7 years ago

the max, min buttons, close? Yes - open raven - general - at the bottom you can switch between left and right.

Elbullazul commented 7 years ago

@fossfreedom so I have the panel ready, will start work on sidebar

fossfreedom commented 7 years ago

excellent. cheers.

a slight aside. which fonts and iconset do you recommend to best show off this theme?

On 11 Jun 2017 18:57, B00merang Project notifications@github.com wrote:

@fossfreedomhttps://github.com/fossfreedom so I have the panel ready, will start work on sidebar

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/B00merang-Project/macOS-Sierra/issues/50#issuecomment-307645651, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AA8zkD8briQK6s3BbKyUQEAtHQ1svpO5ks5sDCpxgaJpZM4NiGnU.

Elbullazul commented 7 years ago

@fossfreedom uh, I don't recommend a particular font, but it should be a sans and if possible light font (not too thick caracters)

the icon theme I recommend are la capitaine or the macbuntu icon pack

I just finished editing the code, just one or two bugs left, maybe you can help me? I'll upload a screenshot in short

Elbullazul commented 7 years ago

here is what I've done so far:

budgie-desktop-macos budgie-sidebar-macos

the bug concerns the light frame around the sidebar. Do you happen to know what class it uses or a way to inspect the software to find out?

cybre commented 7 years ago

https://github.com/budgie-desktop/budgie-desktop/blob/master/src/theme/3.20/sass/_main.scss#L745

Elbullazul commented 7 years ago

@cybre thanks, it's fixed now with a couple other things

Elbullazul commented 7 years ago

@fossfreedom all right, I think it should work ok in budgie

fossfreedom commented 7 years ago

image

The panel is more pink/purple than the README pictures - expected?

plus lots of errors reported in the terminal. thoughts?

Elbullazul commented 7 years ago

no, maybe I skipped a part of the code on upload

will check this afternoon

Elbullazul commented 7 years ago

I found this thread (https://github.com/nana-4/Flat-Plat/issues/95) and you say you only support themes with a PPA. Has this changed?

fossfreedom commented 7 years ago

We've moved on from that. We now create .deb's where debian packages don't exist in PPA's.

Once the necessary changes are done for snaps - we'll be reworking and publishing for every distro that support snaps.

Elbullazul commented 7 years ago

@fossfreedom runs fine without errors on my side

fossfreedom commented 7 years ago

@Elbullazul

To see the theme errors I ran the following:

budgie-panel --replace &

This restarts the panel and any theming issues are then reported as the panel is populated with its various widgets.

fossfreedom commented 7 years ago

on a related matter:

untitled

You'll see the transparent drop down menu for the radiotray icon

sudo apt install radiotray
radiotray &

The widget is a GTK MenuBar / GTKMenuItem

Elbullazul commented 7 years ago

@fossfreedom ok, will check that

to clarify my last comment, I meant to say I had corrected the errors listed, sorry for my bad english

Elbullazul commented 7 years ago

@fossfreedom sorry for the long wait, I've been busier than normal. Will check this in the coming days

amrithmmh commented 6 years ago

i am trying to make similar theme but i cannot make raven translucent/transparent...i used your theme .css for reference can you help me out? i can send you the theme ...can you tell me how to make the raven transparent?

screenshot from 2018-01-16 13-44-19 screenshot from 2018-01-18 13-03-13 screenshot from 2018-01-18 13-03-33

amrithmmh commented 6 years ago

https://drive.google.com/drive/folders/1YoHu_tXuLV2-O3EJKtpPxI6f9eMm3uLc?usp=sharing

Elbullazul commented 6 years ago

If I remember correctly, all budgie specific code is contained in this file: https://github.com/B00merang-Project/macOS-Sierra/blob/master/gtk-3.20/apps/budgie.css

It's almost vanilla budgie code, except for color changes and buttons, switches and separators

Elbullazul commented 6 years ago

Nice looking theme BTW

amrithmmh commented 6 years ago

the thing is if i give opacity:0.7 or some value it gets translucent but after sliding out completely it becomes non transparent. i cannot understand that part..i looked at other themes built for budgie but they are all made using scss/sass kind of complicated for me

Elbullazul commented 6 years ago

@amrithmmh don't use opacity: define a rgba color or a hex color and use the alpha function (if you forked arc, you're probably good with using RGBAs)

the concerned code is the following:

.raven .menu,
.budgie-polkit-dialog .menu,
.raven menu,
.budgie-polkit-dialog menu {
    margin:4px;
    padding:0;
    border-radius:0;
    background-color: alpha(@raven_bg_color,0.93); }

but most importantly

.raven {
    color:@budgie_fg_color;
    background-color: alpha(@raven_bg_color, 0.95);
    transition:170ms ease-out; }

In my code I used hex color + alpha for color coherence, but you're probably better using an rgba color

amrithmmh commented 6 years ago

@Elbullazul thank you very much