GNOME Shell: Top-bar icons and Looking Glass background

B00merang-Project / macOS

macOS theme for Gnome and GTK-based desktops

http://b00merang.weebly.com/macos.html

GNU General Public License v3.0

744 stars 118 forks source link

GNOME Shell: Top-bar icons and Looking Glass background #91

Closed pradyunsg closed 4 years ago

pradyunsg commented 4 years ago

Would you be willing to accept PRs for gnome-shell, modifying:

Looking Glass colors: Currently, the white background + white text is not readable. To access this, pres Alt+F2, type lg and press enter. It will open Looking Glass, which can be used during GNOME Shell (or GNOME shell extension) development.
The unstyled close, maximize and minimize icons in the top bar: they show up when a window is full screen (the buttons in Firefox are a Firefox-specific feature to disable title bar, that I'm using as a reference, for replicating in the top-bar).

Screenshot from 2020-03-19 15-08-13

Elbullazul commented 4 years ago

hello, @pradyunsg feel free to submit pr. Please also include screenshot of the final result when submitting

regards,

pradyunsg commented 4 years ago

Looks like the top bar icons would be tricky, since they're StIcon objects so... can't really be styled. Any ideas on how to deal with that?

I'll file a PR for the Looking Glass situation later today.

Elbullazul commented 4 years ago

I'd look at the extension's source code. maybe they have some differentiating values...

or get the nth child of the parent (1st is close, 2nd would be min, etc.)

pradyunsg commented 4 years ago

Is it an extension? I think it's vanilla GNOME's behavior to move window-controls to the top bar, on full screen.

Elbullazul commented 4 years ago

last time I used gnome, yeah

dominichayesferen commented 4 years ago

@pradyunsg You're probably using the Unite (or IIRC that's its name) extension on GNOME.

pradyunsg commented 4 years ago

Oh heck. Indeed.

Majaro ships with too many things out of the box. Looks like that extension does have the ability to tweak the theme in it locally, so I'll skip that.

That only leaves Looking Glass. That's an easy PR. I'll file it in few hours. :)