B00ze64 / FF-Menu-Icon-Plus-CSS

Add icons to Firefox menus using userChrome/userContent.css
Other
20 stars 3 forks source link

Scroll arrows pointlessly appearing #4

Closed mzso closed 3 years ago

mzso commented 3 years ago

Hi!

I tried this (with silk theme), and immediately noticed this issue. Both tools and context menu shows the scroll arrows by default. There would be no reason to scroll. The scrollbutton actully covers one menu item.

(FF 83 dev edition)

B00ze64 commented 3 years ago

You'll have to provide a screenshot as I do not have this issue with my FF83. This /could/ happen with the SVG icons (context menu only) since there is one icon I use which is bigger than 16x16, but not with Silk or other PNG icons...

mzso commented 3 years ago

@B00ze64 commented on 2020. nov. 27. 03:16 CET:

You'll have to provide a screenshot as I do not have this issue with my FF83. This /could/ happen with the SVG icons (context menu only) since there is one icon I use which is bigger than 16x16, but not with Silk or other PNG icons...

I tried, but didn't use SVG icons, because they were monochrome stuff. It looks like this:

2020-11-27_20-02-35.mp4.zip

B00ze64 commented 3 years ago

Why d'you make a video? Just paste a screenshot into here on Github, I need to see what entries you have in those menus...

mzso commented 3 years ago

Why d'you make a video? Just paste a screenshot into here on Github, I need to see what entries you have in those menus...

Well, it shows that, and more. It's more informative. The arrow also appeared for a context menu that only had a single menu item.

mzso commented 3 years ago

@B00ze64 commented on 2020. nov. 28. 04:46 CET:

Why d'you make a video? Just paste a screenshot into here on Github, I need to see what entries you have in those menus...

It seems like all menus are affected, context or otherwise. Page action context menus are the most absurd where there is a single item covered by an (often flickering) scroll arrow.

B00ze64 commented 3 years ago

Well, I am unable to reproduce this, sorry, and flickering arrows are definitively not caused by this CSS. You must have other CSS that plays with the menus. Try removing all the "margin-top: 2px;" entries, see if that helps. Or maybe you are using some weird DPI setting or something...

B00ze64 commented 3 years ago

Alright, I tried changing Windows' Text Zoom setting - I use 100% here but on high-DPI screens it uses 125% or 150% by default. That made little arrows appear at the bottom of the menus (not at the top). To fix this will require removing "margin-top: 2px;" from the CSS. Try it, just use search/replace to get rid of that line everywhere in the Silk CSS. Let me know if that fixes it for you.

mzso commented 3 years ago

@B00ze64 I see. I do have a custom DPI set (150%) Thanks for the tip. It seems to have alleviated the problem. So far I haven't seen the scroll arrow in any menu that I could think to try.

B00ze64 commented 3 years ago

I had not thought of this when I first replied to you, then 30 minutes later I was reading something on Aris-t2's Github and someone mentioned DPI Scaling and there you go, I'd found the possible cause. Thanks for reporting the issue, I've pushed Release v1.4. Resolving this ticket.

mzso commented 3 years ago

Hi! I recently reset windows. And I set DPI to 175% instead of 150%. And the scroll arrows re-appeared. So it seems the CSS doesn't work for everybody. I want back to 150%. So far so good.

B00ze64 commented 3 years ago

Hey. Well, the CSS is a work-around for Firefox not letting us change the CLASS of the menu items to menu-iconic using CSS. Firefox does its best to cope with the work-around but it's quite possible it does not work too well in some circumstances.

mzso commented 3 years ago

@B00ze64 commented on 2021. ápr. 13. 04:43 CEST:

Hey. Well, the CSS is a work-around for Firefox not letting us change the CLASS of the menu items to menu-iconic using CSS. Firefox does its best to cope with the work-around but it's quite possible it does not work too well in some circumstances.

I thought it was maybe fixable, so I reported it.