B0ney / xmodits

A tool to rip samples from tracker modules. Supports IT, XM, S3M, MOD, UMX and MPTM formats.
GNU General Public License v3.0
67 stars 4 forks source link

Application crashes with certain problematic MOD files. #23

Closed ferro4prez closed 1 year ago

ferro4prez commented 1 year ago

image

This happened on a subfolder "A" of the full modarchive torrent, and is reproducible on subsequent runs, but I can't identify the offending MOD (xm?) because of the crash.

B0ney commented 1 year ago

Oh? That's very interesting. I was convinced that the SoundTracker implementation was the culprit, but turns out it was from Extended Module 😅

If you're wondering how the XM format got involved despite ripping a folder of MODs:

Fixing the crash is fairly easy to do. When I publish the hot-fix, you should have an easier time identifying the cursed "mod".

B0ney commented 1 year ago

I'm having a bit of trouble publishing the hot-fix. Here's a nightly link to the builds: https://nightly.link/B0ney/xmodits/actions/runs/4118482328

ferro4prez commented 1 year ago

Success!

It got through and listed the problem files, but no crash.

Thank you !

On Tue, Feb 7, 2023 at 1:53 PM B0ney @.***> wrote:

I'm having a bit of trouble publishing the hot-fix. Here's a nightly link to the builds: https://nightly.link/B0ney/xmodits/actions/runs/4118482328

— Reply to this email directly, view it on GitHub https://github.com/B0ney/xmodits/issues/23#issuecomment-1421507238, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG326RPWZID7BJTQDVTBVSTWWK735ANCNFSM6AAAAAAUUKNF34 . You are receiving this because you authored the thread.Message ID: @.***>

B0ney commented 1 year ago

Awesome! The file that previously crashed the program will now return this error:

This module has caused an out of bounds error. This is a bug. Please add this module to your bug report.
ferro4prez commented 1 year ago

This is great, thank you so much!

And if you do fix the sample-rate octave issue, happy to test anytime.

On Wed, Feb 8, 2023 at 11:53 AM B0ney @.***> wrote:

Awesome! The file that previously crashed the program will now return this error:

This module has caused an out of bounds error. This is a bug. Please add this module to your bug report.

— Reply to this email directly, view it on GitHub https://github.com/B0ney/xmodits/issues/23#issuecomment-1423160721, or unsubscribe https://github.com/notifications/unsubscribe-auth/AG326RJ7AX3N3URF7C3CYF3WWP2UNANCNFSM6AAAAAAUUKNF34 . You are receiving this because you authored the thread.Message ID: @.***>