B1n-ry / Youre-in-grave-danger

A minecraft mod which adds one single block. The grave, which will generate when you die, and store your items
https://www.curseforge.com/minecraft/mc-mods/youre-in-grave-danger
MIT License
65 stars 18 forks source link

1.19.4 Crashes with Numismatic Overhaul #114

Closed Cirvel closed 1 year ago

Cirvel commented 1 year ago

Describe the bug Dying while having coins from Numismatic Overhaul causes the game to crash.

To Reproduce Steps to reproduce the behavior:

  1. Have any coins inside the purse
  2. Die in any way

Expected behavior The game does not crash when dying in such circumstances.

Desktop

Additional context The tested version for Numismatic Overhaul is 0.2.9.

B1n-ry commented 1 year ago

I swear this worked in my testing... I've been looking at this for a moment now and I kinda think this is more of an issue with owo lib or numismatic overhaul. I'm pretty sure I'm calling on the methods I use in an appropriate way, but I could be wrong. The issue lies within owo lib though. Or numismatic overhaul. Depends on how owo lib is supposed to work. At least I don't think I can do much about this...

Cirvel commented 1 year ago

Can't blame you, the current Numismatic Overhaul mod for 1.19.4 is tagged as a beta after all, so it should be expected that there are bugs within it. I'm just gonna hold that mod off for now, I prefer not having all my stuff lost to lava or despawning.

B1n-ry commented 1 year ago

I created an issue on their github, and by the looks of it it's fixed in development and will be officially fixed in the next update of owo-lib. You can check out the other issue here. I'll close this issue once it's officially fixed

B1n-ry commented 1 year ago

The issue seems to be fixed in the latest release of owo-lib. Thanks for bringing this to my attention