Closed neinwhal closed 8 months ago
Yeah I have gone past this thinking to myself "why didn't I include that?". I think this would do the trick, there's just the issue what happens when someone updates, and the config system is changed. Most likely, they will get an error about the config file containing the wrong information. I will take an extra look to see if I can fix this in some way though. Will probably move some stuff around, to fit more with namings and such if I find a way to implement this, but thank you anyway for taking the time to write this. I will look over the PR again when I have time, probably next weekend
I've added this in commit 5676a19b3070b42e00d750ffb91ca055744d4e54. Changed a few things from this PR, but only config names and such, to keep it in style with the rest of the config. I was able to avoid the config error by just renaming customSoulboundEnchant
to soulboundEnchant
in the configs. I also added the same configurability for the deathsight enchantment, although that enchantment is disabled by default.
I'm closing this PR without merging because I already implemented it. That's what I found easiest so that's what I did. I will make sure to release the update within the next few days
This adds further options for users to customize their own version of soulbound, in particular it controls the various options of the enchanted book. To make it neater, i moved soulbound into its own category for the configs, and match a similar format as with the other enchantment. By default, soulbound is set to treasure enchant true, and villager trading true, as per your previous default configuration.
It's my first attempt at modding something here, so do correct me if i did something wrong.