search

B1n-ry / Youre-in-grave-danger

A minecraft mod which adds one single block. The grave, which will generate when you die, and store your items
https://www.curseforge.com/minecraft/mc-mods/youre-in-grave-danger
MIT License
65 stars 18 forks source link

Check Trinkets drop rule (Item Dupe) #75

Closed jakeb072001 closed 2 years ago

jakeb072001 commented 2 years ago

Hi, seems that my mod TerraMine may have some issues with this mod where my items duplicate. As far as I can tell this Is because my trinket slots are set to keep their inventory, so I assume they are being added to the grave and kept in inventory. Best way to fix this is to check the drop rule for the trinket slots. Trinkets code may help with this (dropInventory), this can also add support for the delete drop rule which just deletes the trinkets and shouldn't put them in a grave or drop them.

B1n-ry commented 2 years ago

I have to be honest, I saw that trinkets had a drop rule quite some time ago, but I had completely forgotten about it. I'll do my best to implement this in the mod. Thanks for pointing it out!

B1n-ry commented 2 years ago

I'm sorry for this taking so long. I've had to wait for some other mods to update, but now they have updated and I can work on the mod again. I've written a simple implementation but for the time being I can't seem to find which items/slots to test the feature on/with. Could you help me in saying how I should test this? (what items to use for example)

jakeb072001 commented 2 years ago

I quickly made a test mod you can use that has one of each drop rule, it also includes a trinket you can equip into these slots. The item is just called Example Trinket. The duplication was reported to me by someone else but I don't get the duplication myself, however the items do still get added to the grave when they shouldn't.

example-trinkets-1.0.zip

The jar is in the zip btw.

B1n-ry commented 2 years ago

Thanks a bunch! My implementation seemed to work, and I've now pushed an update to github, curseforge and modrinth. Really like your mod btw. Always cool to see things from terraria in minecraft, but especially stuff like corruption! Keep up the good work, and thanks again for the help!