Checking for back-links (in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)

B2theRandino / iui

Automatically exported from code.google.com/p/iui

MIT License

0 stars 0 forks source link

Checking for back-links (in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added) #346

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago

1. Click on a link and let a new page slide in.
2. In the new page click on a link to #home

Expected result:  iUI returns to #home with a backwards scroll

Incorrect result: iUI pushes #home on the nav stack and does a forward scroll 
to home

Original issue reported on code.google.com by msgilli...@gmail.com on 22 Jul 2012 at 12:08

GoogleCodeExporter commented 8 years ago

I added a test-case for easy reproduction here:
https://github.com/iui/iUI/commit/a1d0fd6217317ce01ec1f77fc7df0c6ca6333280

Original comment by msgilli...@gmail.com on 22 Jul 2012 at 12:19

GoogleCodeExporter commented 8 years ago

This change cleans up iui.busy handling for ajax links (but does not fix the 
bug)
https://github.com/iui/iUI/commit/b3de1ca14c95434d748c2395a5530b8997adb35a

Original comment by msgilli...@gmail.com on 22 Jul 2012 at 12:20

GoogleCodeExporter commented 8 years ago

This is the commit that actually fixes the bug:
https://github.com/iui/iUI/commit/c348613cd2e8db45aeb3a37daf1937eff257b563

Original comment by msgilli...@gmail.com on 22 Jul 2012 at 12:20

GoogleCodeExporter commented 8 years ago

Remi, why don't you check out the changes on comment on them on GitHub.

(Yes, I think it's time to make GitHub our primary code repository...)

Original comment by msgilli...@gmail.com on 22 Jul 2012 at 12:22

GoogleCodeExporter commented 8 years ago

I want to take a closer look at the code that decides whether "view" is a node 
or a node ID string.  That may not be done properly for cross-browser.

Original comment by msgilli...@gmail.com on 22 Jul 2012 at 9:39