B3Pay / B3Wallet

B3Wallet: A decentralized, multi-chain wallet with unique support for Bitcoin, Ethereum, using Internet Computer's threshold ECDSA. Manage multiple accounts and owners securely and efficiently with this open-source solution.
https://mnrs5-4qaaa-aaaap-abc5a-cai.icp0.io/
MIT License
31 stars 10 forks source link

Should the ```deps``` folder go to ```.gitignore```? #32

Closed sadernalwis closed 11 months ago

sadernalwis commented 11 months ago

Should the deps folder go to .gitignore?

Seems like it generates automatically, however might have to copyinit.json after

dfx deps pull
dfx deps init

because after a run, the working tree shows changes. Have to manually remove or untrack.

sadernalwis commented 11 months ago

image

also yarn.lock

b3hr4d commented 11 months ago

Yeah you are right, when we pull, the new II update will change the pulled.json. Thank you, I'll put pulled.json, and candid folder into .gitignore.

sadernalwis commented 11 months ago

Nice. what about yarn.lock? It seems to be in the .gitignore but seems to be tracked for some reason.

b3hr4d commented 11 months ago

Fixed with this commit, that's because I didn't delete it after put "yarn.lock" inside .gitignore.

sadernalwis commented 11 months ago

Perfect! Closing this.