B3akers / LeagueSkinChanger

Skin changer for League of Legends
MIT License
236 stars 74 forks source link

cannot bring up the menu #105

Closed dxxxxy closed 3 years ago

dxxxxy commented 3 years ago

Injector says [+] Injected successfully!. However pressing Insert does nothing.

OktarPwnar commented 3 years ago

Because you need to update offets. Check under issues - if you have a visual studio you can edit the given data within 10 sec and compile it up yourself :)

edit :

here from one of our contributors, what to do :

Update these sigs: Open autoupdater.cpp and replace SkinId, and characterdatastack_update to these:

SkinID: 80 BE ? ? ? ? ? 75 4D 0F 31 33 C9 66 C7 86 ? ? ? ? ? ? 89 44 24 18 33 FF CharacterDataStack_Update = 83 EC 2C 53 56 57 8D 44 24 28

dxxxxy commented 3 years ago

Because you need to update offets. Check under issues - if you have a visual studio you can edit the given data within 10 sec and compile it up yourself :)

edit :

here from one of our contributors, what to do :

Update these sigs: Open autoupdater.cpp and replace SkinId, and characterdatastack_update to these: SkinID: 80 BE ? ? ? ? ? 75 4D 0F 31 33 C9 66 C7 86 ? ? ? ? ? ? 89 44 24 18 33 FF CharacterDataStack_Update = 83 EC 2C 53 56 57 8D 44 24 28

aah thats a shame, i uninstalled it not long ago, i guess i have to wait till dev updates them?

OktarPwnar commented 3 years ago

You can do either that or you take a risk and download updated version. Check issues where someone posted it. But of course it on your own risk. You can always go for trial visual studio and update it yourself. This shit (almost) changes every major patch so it's handy to have it :).

Also there is a guy who did fork of this and 'redeveloping' it (also under issues somewhere)

Cheers

dxxxxy commented 3 years ago

You can do either that or you take a risk and download updated version. Check issues where someone posted it. But of course it on your own risk. You can always go for trial visual studio and update it yourself. This shit (almost) changes every major patch so it's handy to have it :).

Also there is a guy who did fork of this and 'redeveloping' it (also under issues somewhere)

Cheers

alright, thanks for the fast response. have a great day

dxxxxy commented 3 years ago

so uh i replaced the offsets and now i crash everytime it injects

OktarPwnar commented 3 years ago

Try to :

extra :

dxxxxy commented 3 years ago

try everything, even tried using a fork of this which improved the situation by not making me immediately crash, but crash later in 3mins. everytime the error in the injector is "failed to alloc space"

OktarPwnar commented 3 years ago

Weird. I cannot help you at this point on because it works for me - did not really sink into this, just using it.

Also checked it out right now in custom game just to make sure i am not trolling you and it works. I'm sorry mate.

OktarPwnar commented 3 years ago

Btw ... even for me it says : [-] Failed to alloc space! after every game ... but ingame it's ok - did you try to press INSERT?

dxxxxy commented 3 years ago

Btw ... even for me it says : [-] Failed to alloc space! after every game ... but ingame it's ok - did you try to press INSERT?

no it instantly crashes when everyone spawns (after 100% loading)

dxxxxy commented 3 years ago

but i have a question, when are you supposed to inject? i just keep injector open all the time and it injects by itself after champ select when the game starts loading

dxxxxy commented 3 years ago

misclick

OktarPwnar commented 3 years ago

You are supposed to have it open for nonstop. Then it will detect the game and inject - after the game it will say failed to alloc ... and when you go another game it will say successfully injected etc. So you are 100% sure you download fork .zip package with executables and ran .exe as administrator and it does not work? Are you using windows 10 or any other os? It works on win10 - really have zero clue why would it crash. Delete everything in temp folder / restart pc ... dunno what the hack could cause that tbh.

codexJoin commented 3 years ago

misclick

Maybe you replaced the sigs to change are always above the defined name, never below

dxxxxy commented 3 years ago

image these are how my sigs look, and yes im using win10

codexJoin commented 3 years ago

You changed data stack. You need to chamge data stack update, not data stack!!!

dxxxxy commented 3 years ago

You changed data stack. You need to chamge data stack update, not data stack!!!

oh crap, i did not pay attention to that, do you have the old characterdatastack sig so i can replace it?

dxxxxy commented 3 years ago

nvm i got it ill go try it out right now

codexJoin commented 3 years ago

Restore your character data stack to original: "8D 8E ? ? ? ? FF 74 24 4C" and change these again:

SkinID: 80 BE ? ? ? ? ? 75 4D 0F 31 33 C9 66 C7 86 ? ? ? ? ? ? 89 44 24 18 33 FF CharacterDataStack_Update = 83 EC 2C 53 56 57 8D 44 24 28

https://i.imgur.com/xhKJ8gq.png https://i.imgur.com/oz6XlT3.png

dxxxxy commented 3 years ago

Restore your character data stack to original: "8D 8E ? ? ? ? FF 74 24 4C" and change these again:

SkinID: 80 BE ? ? ? ? ? 75 4D 0F 31 33 C9 66 C7 86 ? ? ? ? ? ? 89 44 24 18 33 FF CharacterDataStack_Update = 83 EC 2C 53 56 57 8D 44 24 28

https://i.imgur.com/xhKJ8gq.png https://i.imgur.com/oz6XlT3.png

it works flawlessly thank you! appreciate the support for such a dumb mistake haha