search

B3akers / LeagueSkinChanger

Skin changer for League of Legends
MIT License
239 stars 75 forks source link

Skin bugs #44

Open amir2204musin opened 3 years ago

amir2204musin commented 3 years ago

Are they fixed? Like rumble q, god fist lee etc.

Clownsw commented 3 years ago

Maybe he needs time

ghost commented 3 years ago

I checked issue, problem is that on server you still have default skin, some skins have special VO and it's different packet, for example LeeSin has "Laugh3D" (like most skins/champions) but Storm Dragon Lee Sin has "Laugh3D" (which is empty sound) and "Laugh3DGeneral" which is send by server in diffrent packet since for server you have still default skin it will not send packet to play "Laugh3DGeneral", that is why in some skins VO doesn't work, or just play original, i can fix it by emulating server but then i have to add VO manually for each skin which doesn't work -maker of skin changer

ghost commented 3 years ago

Probably same issue like other skins, some skins has special object which information about creation are sends by server, since we use skinchanger server doesn't know about our skin and addional partciles effects will not show up, i will try to fix that but it a lot of work.

ghost commented 3 years ago

15