search

B3n30 / tunnler

GNU General Public License v2.0
1 stars 0 forks source link

Implemented connecting to the rooms. #6

Closed Subv closed 7 years ago

Subv commented 7 years ago

Nicknames and MAC addresses are not yet negotiated. Only wifi beacon frames are retransmitted for the moment.

Moved the header files to a tunnler/ subdirectory.

There are still some concurrency issues that i'd like help with, namely in RoomMember.

Subv commented 7 years ago

Addressed some @JayFoxRox comments.

JayFoxRox commented 7 years ago

We are discussing minuscule things by now. I feel like this has been discussed enough. So I suggest keeping "nits" to yourself at this point and only address actual design issues.

@Subv please handle the latest review comments; then make sure this code is compilable so we can merge this to master asap (just handle the remaining review comments). We should have a stable master as base to work on for more important things.

(If remaining design or code issues are found we can discuss them in GitHub issues or add comments after the merge)

JayFoxRox commented 7 years ago

This looks good now, basicly this C14 thing and an edge-case. Merge please :) We can then do follow up PRs

B3n30 commented 7 years ago

For me LGTM...

Subv commented 7 years ago

LGTM, let's merge it and iterate on it with further PRs