Doesn't work for popup settings menu

B3nedikt / AppLocale

AppLocale is a android library to update the app language dynamically.

Apache License 2.0

135 stars 10 forks source link

Doesn't work for popup settings menu #23

Closed bakhadev closed 3 years ago

bakhadev commented 4 years ago

hello, library doesn't work or not translate setting popup menu created with onCreateOptionsMenu.

B3nedikt commented 4 years ago

Actually this has been added in Reword 2.1.0, so if you use a version above this it should work: Reword Versions. The example app in the reword repository demonstrates how to integrate a PopupMenu. If you want you can fork it, and recreate your issue by creating a popup menu that does not work like you describe. Then I can look at your fork, and analyze the issue, as soon as I have the time. If you want some feature earlier you are free to create a PR though ;)

B3nedikt commented 3 years ago

Looking at it again, you obviously mean manually inflated popup menus. Yes, this is currently not supported, as the lib does not intercept the MenuInflater. It would be possible to add this to my ViewPump lib, but I don't think it would be worth the time, as most people use menus with the Toolbar nowadays.